jyapayne/moonlight-common-c
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix leak in unreachable codepath

Browse source
This commit is contained in:
Cameron Gutman 2023-09-18 22:59:03 -05:00
commit a258b7e12b
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/SdpGenerator.c
View file

@ -543,6 +543,7 @@ char* getSdpPayloadForStreamConfig(int rtspClientVersion, int* length) {
written = fillSdpHeader(payload, MAX_SDP_HEADER_LEN, rtspClientVersion, urlSafeAddr); written = fillSdpHeader(payload, MAX_SDP_HEADER_LEN, rtspClientVersion, urlSafeAddr);
if (written < 0 || written >= MAX_SDP_HEADER_LEN) { if (written < 0 || written >= MAX_SDP_HEADER_LEN) {
LC_ASSERT(false); LC_ASSERT(false);
free(payload);
freeAttributeList(attributeList); freeAttributeList(attributeList);
return NULL; return NULL;
} }
@ -552,6 +553,7 @@ char* getSdpPayloadForStreamConfig(int rtspClientVersion, int* length) {
written = fillSerializedAttributeList(&payload[offset], attributeListSize, attributeList); written = fillSerializedAttributeList(&payload[offset], attributeListSize, attributeList);
if (written < 0 || written >= attributeListSize) { if (written < 0 || written >= attributeListSize) {
LC_ASSERT(false); LC_ASSERT(false);
free(payload);
freeAttributeList(attributeList); freeAttributeList(attributeList);
return NULL; return NULL;
} }
@ -561,6 +563,7 @@ char* getSdpPayloadForStreamConfig(int rtspClientVersion, int* length) {
written = fillSdpTail(&payload[offset], MAX_SDP_TAIL_LEN); written = fillSdpTail(&payload[offset], MAX_SDP_TAIL_LEN);
if (written < 0 || written >= MAX_SDP_TAIL_LEN) { if (written < 0 || written >= MAX_SDP_TAIL_LEN) {
LC_ASSERT(false); LC_ASSERT(false);
free(payload);
freeAttributeList(attributeList); freeAttributeList(attributeList);
return NULL; return NULL;
} }