jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only call SDL_NumJoysticks() once per loop

Browse source 
It does non-trivial work when using sdl2-compat.
This commit is contained in:
Cameron Gutman 2024-11-12 23:52:31 -06:00
commit 15e337fff8
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/streaming/input/gamepad.cpp
View file

@ -913,7 +913,8 @@ QString SdlInputHandler::getUnmappedGamepads()
MappingManager mappingManager;
mappingManager.applyMappings();
for (int i = 0; i < SDL_NumJoysticks(); i++) {
int numJoysticks = SDL_NumJoysticks();
for (int i = 0; i < numJoysticks; i++) {
if (!SDL_IsGameController(i)) {
char guidStr[33];
SDL_JoystickGetGUIDString(SDL_JoystickGetDeviceGUID(i),
@ -973,7 +974,8 @@ int SdlInputHandler::getAttachedGamepadMask()
}
count = mask = 0;
for (int i = 0; i < SDL_NumJoysticks(); i++) {
int numJoysticks = SDL_NumJoysticks();
for (int i = 0; i < numJoysticks; i++) {
if (SDL_IsGameController(i)) {
char guidStr[33];
SDL_JoystickGetGUIDString(SDL_JoystickGetDeviceGUID(i),