jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix UAF in SLVideo overlay update

Browse source
This commit is contained in:
Cameron Gutman 2022-05-21 00:30:07 -05:00
commit 216f274a92
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/streaming/video/slvid.cpp
View file

@ -204,14 +204,14 @@ void SLVideoDecoder::notifyOverlayUpdated(Overlay::OverlayType type)
SDL_ConvertPixels(newSurface->w, newSurface->h, newSurface->format->format, newSurface->pixels, newSurface->pitch, SDL_ConvertPixels(newSurface->w, newSurface->h, newSurface->format->format, newSurface->pixels, newSurface->pitch,
SDL_PIXELFORMAT_ARGB8888, pixels, pitch); SDL_PIXELFORMAT_ARGB8888, pixels, pitch);
// We're done with the surface now
SDL_FreeSurface(newSurface);
// Position the status overlay at the bottom left corner // Position the status overlay at the bottom left corner
float flWidth = (float)newSurface->w / m_ViewportWidth; float flWidth = (float)newSurface->w / m_ViewportWidth;
float flHeight = (float)newSurface->h / m_ViewportHeight; float flHeight = (float)newSurface->h / m_ViewportHeight;
SLVideo_SetOverlayDisplayArea(m_Overlay, 0.0f, 1.0f - flHeight, flWidth, flHeight); SLVideo_SetOverlayDisplayArea(m_Overlay, 0.0f, 1.0f - flHeight, flWidth, flHeight);
// We're done with the surface now
SDL_FreeSurface(newSurface);
// Show the overlay // Show the overlay
SLVideo_ShowOverlay(m_Overlay); SLVideo_ShowOverlay(m_Overlay);
} }