jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix double-free in Vulkan renderer when an overlay is disabled

Browse source 
Also a drive-by fix to avoid pl_tex copying
This commit is contained in:
Cameron Gutman 2026-02-04 23:05:01 -06:00
commit 8795fb54f4
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/streaming/video/ffmpeg-renderers/plvk.cpp
View file

@ -806,6 +806,7 @@ void PlVkRenderer::renderFrame(AVFrame *frame)
// If we have an overlay but it's been disabled, free the overlay texture // If we have an overlay but it's been disabled, free the overlay texture
if (m_Overlays[i].hasOverlay && !Session::get()->getOverlayManager().isOverlayEnabled((Overlay::OverlayType)i)) { if (m_Overlays[i].hasOverlay && !Session::get()->getOverlayManager().isOverlayEnabled((Overlay::OverlayType)i)) {
texturesToDestroy.push_back(m_Overlays[i].overlay.tex); texturesToDestroy.push_back(m_Overlays[i].overlay.tex);
SDL_zero(m_Overlays[i].overlay);
m_Overlays[i].hasOverlay = false; m_Overlays[i].hasOverlay = false;
} }
@ -884,7 +885,7 @@ void PlVkRenderer::renderFrame(AVFrame *frame)
UnmapExit: UnmapExit:
// Delete any textures that need to be destroyed // Delete any textures that need to be destroyed
for (pl_tex texture : texturesToDestroy) { for (pl_tex& texture : texturesToDestroy) {
pl_tex_destroy(m_Vulkan->gpu, &texture); pl_tex_destroy(m_Vulkan->gpu, &texture);
} }