jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert macOS audio buffer size workaround

Browse source 
This causes excessive glitching and needs to be fixed by Apple (if it hasn't already in the 2 years since the report).
This commit is contained in:
Cameron Gutman 2025-10-23 21:42:44 -05:00
commit c7bc76325f
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/streaming/audio/renderers/sdlaud.cpp
View file

@ -30,14 +30,7 @@ bool SdlAudioRenderer::prepareForPlayback(const OPUS_MULTISTREAM_CONFIGURATION*
// to mitigate this issue. Otherwise, we will buffer up to 3 frames of audio which // to mitigate this issue. Otherwise, we will buffer up to 3 frames of audio which
// is 15 ms at regular 5 ms frames and 30 ms at 10 ms frames for slow connections. // is 15 ms at regular 5 ms frames and 30 ms at 10 ms frames for slow connections.
// The buffering helps avoid audio underruns due to network jitter. // The buffering helps avoid audio underruns due to network jitter.
#ifndef Q_OS_DARWIN
want.samples = SDL_max(480, opusConfig->samplesPerFrame * 3); want.samples = SDL_max(480, opusConfig->samplesPerFrame * 3);
#else
// HACK: Changing the buffer size can lead to Bluetooth HFP
// audio issues on macOS, so we're leaving this alone.
// https://github.com/moonlight-stream/moonlight-qt/issues/1071
want.samples = SDL_max(480, opusConfig->samplesPerFrame);
#endif
m_FrameSize = opusConfig->samplesPerFrame * m_FrameSize = opusConfig->samplesPerFrame *
opusConfig->channelCount * opusConfig->channelCount *