jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't use vaPutSurface() if there are no valid subpicture formats

Browse source
This commit is contained in:
Cameron Gutman 2025-12-05 23:52:41 -06:00
commit c92dc2495e
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/streaming/video/ffmpeg-renderers/vaapi.cpp
View file

@ -603,6 +603,15 @@ VAAPIRenderer::isDirectRenderingSupported()
"Using indirect rendering for YUV 4:4:4 video"); "Using indirect rendering for YUV 4:4:4 video");
return false; return false;
} }
else if (m_OverlayFormat.fourcc == 0) {
// We ordinarily wouldn't consider lack of overlay support to be a
// dealbreaker for picking a renderer, however the only cases I've
// ever seen overlay format selection fail is on systems that will
// also silently fail in vaPutSurface() too.
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Using indirect rendering due to lack of overlay support");
return false;
}
AVHWDeviceContext* deviceContext = (AVHWDeviceContext*)m_HwContext->data; AVHWDeviceContext* deviceContext = (AVHWDeviceContext*)m_HwContext->data;
AVVAAPIDeviceContext* vaDeviceContext = (AVVAAPIDeviceContext*)deviceContext->hwctx; AVVAAPIDeviceContext* vaDeviceContext = (AVVAAPIDeviceContext*)deviceContext->hwctx;
@ -615,12 +624,6 @@ VAAPIRenderer::isDirectRenderingSupported()
if (entrypoints[i] == VAEntrypointVideoProc) { if (entrypoints[i] == VAEntrypointVideoProc) {
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION, SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Using direct rendering with VAEntrypointVideoProc"); "Using direct rendering with VAEntrypointVideoProc");
if (m_OverlayFormat.fourcc == 0) {
SDL_LogWarn(SDL_LOG_CATEGORY_APPLICATION,
"Unable to find supported subpicture format. Overlays will be unavailable!");
}
return true; return true;
} }
} }