jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Print flip stats after the DrmRenderer is destroyed

Browse source
This commit is contained in:
Cameron Gutman 2026-01-05 20:50:16 -06:00
commit d14cf984f4
1 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

32
app/streaming/video/ffmpeg-renderers/drm.h
View file

@ -236,6 +236,13 @@ class DrmRenderer : public IFFmpegRenderer {
if (m_AtomicReq) { if (m_AtomicReq) {
drmModeAtomicFree(m_AtomicReq); drmModeAtomicFree(m_AtomicReq);
} }
if (m_TotalCommits != 0) {
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Flip stats: %.2f%% async | %.2f%% sync",
(float)m_AsyncCommits / (float)m_TotalCommits,
(float)(m_TotalCommits - m_AsyncCommits) / (float)m_TotalCommits);
}
} }
DrmPropertySetter(const DrmPropertySetter &) = delete; DrmPropertySetter(const DrmPropertySetter &) = delete;
@ -520,14 +527,23 @@ class DrmRenderer : public IFFmpegRenderer {
m_AsyncFlip ? DRM_MODE_PAGE_FLIP_ASYNC : DRM_MODE_ATOMIC_ALLOW_MODESET, m_AsyncFlip ? DRM_MODE_PAGE_FLIP_ASYNC : DRM_MODE_ATOMIC_ALLOW_MODESET,
nullptr); nullptr);
// The driver may not support async flips (especially if we changed a non-FB_ID property), if (m_AsyncFlip) {
// so try again with a regular flip if we get an error from the async flip attempt. if (err == 0) {
// m_AsyncCommits++;
// We pass DRM_MODE_ATOMIC_ALLOW_MODESET because changing HDR state may require a modeset. }
if (err < 0 && m_AsyncFlip) { else {
err = drmModeAtomicCommit(m_Fd, req, DRM_MODE_ATOMIC_ALLOW_MODESET, nullptr); // The driver may not support async flips (especially if we changed a non-FB_ID property),
// so try again with a regular flip if we get an error from the async flip attempt.
//
// We pass DRM_MODE_ATOMIC_ALLOW_MODESET because changing HDR state may require a modeset.
err = drmModeAtomicCommit(m_Fd, req, DRM_MODE_ATOMIC_ALLOW_MODESET, nullptr);
}
} }
if (err < 0) {
if (err == 0) {
m_TotalCommits++;
}
else {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, SDL_LogError(SDL_LOG_CATEGORY_APPLICATION,
"drmModeAtomicCommit() failed: %d", "drmModeAtomicCommit() failed: %d",
err); err);
@ -601,6 +617,8 @@ class DrmRenderer : public IFFmpegRenderer {
// Atomic context // Atomic context
drmModeAtomicReqPtr m_AtomicReq = nullptr; drmModeAtomicReqPtr m_AtomicReq = nullptr;
std::atomic<uint32_t> m_AsyncCommits {0};
std::atomic<uint32_t> m_TotalCommits {0};
}; };
public: public: