jyapayne/moonlight-qt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix use-after-free due to stale m_FrontendRenderer pointer. Fixes #214

Browse source
This commit is contained in:
Cameron Gutman 2019-04-18 19:26:13 -07:00
commit e51ad1a68a
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/streaming/video/ffmpeg.cpp
View file

@ -124,11 +124,11 @@ void FFmpegVideoDecoder::reset()
// If we have a separate frontend renderer, free that first // If we have a separate frontend renderer, free that first
if (m_FrontendRenderer != m_BackendRenderer) { if (m_FrontendRenderer != m_BackendRenderer) {
delete m_FrontendRenderer; delete m_FrontendRenderer;
m_FrontendRenderer = nullptr;
} }
delete m_BackendRenderer; delete m_BackendRenderer;
m_BackendRenderer = nullptr;
m_FrontendRenderer = m_BackendRenderer = nullptr;
if (!m_TestOnly) { if (!m_TestOnly) {
logVideoStats(m_GlobalVideoStats, "Global video stats"); logVideoStats(m_GlobalVideoStats, "Global video stats");