jyapayne/musl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

in sem_open, don't leak vm mapping if fstat fails

Browse source 
fstat should not fail under normal circumstances, so this fix is
mostly theoretical.
This commit is contained in:
Rich Felker 2013-06-26 21:35:56 -04:00
commit 52d4444f8e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/thread/sem_open.c
View file

@ -82,8 +82,8 @@ sem_t *sem_open(const char *name, int flags, ...)
if (flags != (O_CREAT|O_EXCL)) { if (flags != (O_CREAT|O_EXCL)) {
fd = open(name, FLAGS); fd = open(name, FLAGS);
if (fd >= 0) { if (fd >= 0) {
if ((map = mmap(0, sizeof(sem_t), PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED || if (fstat(fd, &st) < 0 ||
fstat(fd, &st) < 0) { (map = mmap(0, sizeof(sem_t), PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED) {
close(fd); close(fd);
goto fail; goto fail;
} }