jyapayne/musl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix minor bugs due to incorrect threaded-predicate semantics

Browse source 
some functions that should have been testing whether pthread_self()
had been called and initialized the thread pointer were instead
testing whether pthread_create() had been called and actually made the
program "threaded". while it's unlikely any mismatch would occur in
real-world problems, this could have introduced subtle bugs. now, we
store the address of the main thread's thread descriptor in the libc
structure and use its presence as a flag that the thread register is
initialized. note that after fork, the calling thread (not necessarily
the original main thread) is the new main thread.
This commit is contained in:
Rich Felker 2011-04-20 21:41:45 -04:00
commit 870cc67977
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/process/fork.c
View file

@ -8,10 +8,11 @@ pid_t fork(void)
pid_t ret;
if (libc.fork_handler) libc.fork_handler(-1);
ret = syscall(SYS_fork);
if (libc.threaded && !ret) {
if (libc.main_thread && !ret) {
pthread_t self = __pthread_self();
self->tid = self->pid = syscall(SYS_getpid);
libc.threads_minus_1 = 0;
libc.main_thread = self;
}
if (libc.fork_handler) libc.fork_handler(!ret);
return ret;