document self-synchronized destruction issue for stdio locking
This commit is contained in:
parent
baf246e559
commit
f1c1a5ea82
1 changed files with 10 additions and 0 deletions
|
|
@ -14,5 +14,15 @@ int __lockfile(FILE *f)
|
||||||
void __unlockfile(FILE *f)
|
void __unlockfile(FILE *f)
|
||||||
{
|
{
|
||||||
a_store(&f->lock, 0);
|
a_store(&f->lock, 0);
|
||||||
|
|
||||||
|
/* The following read is technically invalid under situations
|
||||||
|
* of self-synchronized destruction. Another thread may have
|
||||||
|
* called fclose as soon as the above store has completed.
|
||||||
|
* Nonetheless, since FILE objects always live in memory
|
||||||
|
* obtained by malloc from the heap, it's safe to assume
|
||||||
|
* the dereferences below will not fault. In the worst case,
|
||||||
|
* a spurious syscall will be made. If the implementation of
|
||||||
|
* malloc changes, this assumption needs revisiting. */
|
||||||
|
|
||||||
if (f->waiters) __wake(&f->lock, 1, 1);
|
if (f->waiters) __wake(&f->lock, 1, 1);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue