jyapayne/musl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

de-duplicate dn_expand, fix return value and signature, clean up

Browse source 
the duplicate code in dn_expand and its incorrect return values are
both results of the history of the code: the version in __dns.c was
originally written with no awareness of the legacy resolver API, and
was later copy-and-paste duplicated to provide the legacy API.

this commit is the first of a series that will restructure the
internal dns code to share as much code as possible with the legacy
resolver API functions.

I have also removed the loop detection logic, since the output buffer
length limit naturally prevents loops. in order to avoid long runtime
when encountering a loop if the caller provided a ridiculously long
buffer, the caller-provided length is clamped at the maximum dns name
length.
This commit is contained in:
Rich Felker 2013-08-14 17:58:20 -04:00
commit fcc522c923
3 changed files with 24 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/resolv.h
View file

@ -134,7 +134,7 @@ int res_search(const char *, int, int, unsigned char *, int);
int res_mkquery(int, const char *, int, int, char *, int, struct rrec *, char *, int);
int res_send(const char *, int, char *, int);
int dn_comp(unsigned char *, unsigned char *, int, unsigned char **, unsigned char *, unsigned char **);
int dn_expand(unsigned char *, unsigned char *, unsigned char *, unsigned char *, int);
int dn_expand(const unsigned char *, const unsigned char *, const unsigned char *, char *, int);
int dn_skipname(const unsigned char *, const unsigned char *);
#ifdef __cplusplus