From 0cd37a40ef8cabbd73b51d631f2f2970e2971c7d Mon Sep 17 00:00:00 2001
From: konqoro <capoiosct@gmail.com>
Date: Mon, 7 Nov 2016 18:18:23 +0200
Subject: [PATCH] Port the class macro from deprecated: stmt, expr (#42)

* Port the class macro from deprecated: stmt, expr

* Made changes

* Address comments

* Update oop_macro.md
---
 content/content/oop_macro.md | 105 +++++++++++++++++------------------
 1 file changed, 50 insertions(+), 55 deletions(-)

diff --git a/content/content/oop_macro.md b/content/content/oop_macro.md
index 0019d29..d50bdb0 100644
--- a/content/content/oop_macro.md
+++ b/content/content/oop_macro.md
@@ -43,9 +43,9 @@ To get that nice notation, we can use a macro:
 ```nimrod
 import macros
 
-macro class*(head: expr, body: stmt): stmt {.immediate.} =
-  # The macro is immediate so that it doesn't
-  # resolve identifiers passed to it
+macro class*(head, body: untyped): untyped =
+  # The macro is immediate, since all its parameters are untyped.
+  # This means, it doesn't resolve identifiers passed to it.
 
   var typeName, baseName: NimNode
 
@@ -55,6 +55,7 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
     # --------------------
     # Ident !"Animal"
     typeName = head
+    baseName = ident("RootObj")
 
   elif head.kind == nnkInfix and $head[0] == "of":
     # `head` is expression `typeName of baseClass`
@@ -70,6 +71,34 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
   else:
     quit "Invalid node: " & head.lispRepr
 
+  # The following prints out the AST structure:
+  #
+  # import macros
+  # dumptree:
+  #   type X = ref object of Y
+  #     z: int
+  # --------------------
+  # StmtList
+  #   TypeSection
+  #     TypeDef
+  #       Ident !"X"
+  #       Empty
+  #       RefTy
+  #         ObjectTy
+  #           Empty
+  #           OfInherit
+  #             Ident !"Y"
+  #           RecList
+  #             IdentDefs
+  #               Ident !"z"
+  #               Ident !"int"
+  #               Empty
+
+  # create a type section in the result
+  result =
+    quote do:
+      type `typeName` = ref object of `baseName`
+
   # echo treeRepr(body)
   # --------------------
   # StmtList
@@ -105,9 +134,6 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
   #         Ident !"this"
   #         Ident !"age"
 
-  # create a new stmtList for the result
-  result = newStmtList()
-
   # var declarations will be turned into object fields
   var recList = newNimNode(nnkRecList)
 
@@ -119,7 +145,7 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
       of nnkMethodDef, nnkProcDef:
         # inject `this: T` into the arguments
         let p = copyNimTree(node.params)
-        p.insert(1, newIdentDefs(ident"this", typeName))
+        p.insert(1, newIdentDefs(ident("this"), typeName))
         node.params = p
         result.add(node)
 
@@ -131,56 +157,25 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
       else:
         result.add(node)
 
-  # The following prints out the AST structure:
-  #
-  # import macros
-  # dumptree:
-  #   type X = ref object of Y
-  #     z: int
-  # --------------------
-  # TypeSection
-  #   TypeDef
-  #     Ident !"X"
-  #     Empty
-  #     RefTy
-  #       ObjectTy
-  #         Empty
-  #         OfInherit
-  #           Ident !"Y"
-  #         RecList
-  #           IdentDefs
-  #             Ident !"z"
-  #             Ident !"int"
-  #             Empty
-
-  result.insert(0,
-    if baseName == nil:
-      quote do:
-        type `typeName` = ref object of RootObj
-    else:
-      quote do:
-        type `typeName` = ref object of `baseName`
-  )
   # Inspect the tree structure:
   #
   # echo result.treeRepr
   # --------------------
   # StmtList
-  #   StmtList
-  #     TypeSection
-  #       TypeDef
-  #         Ident !"Animal"
-  #         Empty
-  #         RefTy
-  #           ObjectTy
-  #             Empty
-  #             OfInherit
-  #               Ident !"RootObj"
-  #             Empty   <= We want to replace this
-  #   MethodDef
-  #   ...
+  #   TypeSection
+  #     TypeDef
+  #       Ident !"Animal"
+  #       Empty
+  #       RefTy
+  #         ObjectTy
+  #           Empty
+  #           OfInherit
+  #             Ident !"RootObj"
+  #           Empty   <= We want to replace this
+  # MethodDef
+  # ...
 
-  result[0][0][0][2][0][2] = recList
+  result[0][0][2][0][2] = recList
 
   # Lets inspect the human-readable version of the output
   # echo repr(result)
@@ -190,10 +185,10 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
   #      name: string
   #      age: int
   #
-  #  method vocalize(this: Animal): string =
+  #  method vocalize(this: Animal): string {.base.} =
   #    "..."
   #
-  #  method age_human_yrs(this: Animal): int =
+  #  method age_human_yrs(this: Animal): int {.base.} =
   #    this.age
 
 # ---
@@ -201,8 +196,8 @@ macro class*(head: expr, body: stmt): stmt {.immediate.} =
 class Animal of RootObj:
   var name: string
   var age: int
-  method vocalize: string = "..."
-  method age_human_yrs: int = this.age # `this` is injected
+  method vocalize: string {.base.} = "..." # use `base` pragma to annonate base methods
+  method age_human_yrs: int {.base.} = this.age # `this` is injected
 
 class Dog of Animal:
   method vocalize: string = "woof"