jyapayne/nimble
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixes #129.

Browse source
This commit is contained in:
Dominik Picheta 2016-10-08 20:51:19 +02:00
commit 0564cb238a
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/nimblepkg/download.nim
View file

@ -174,12 +174,9 @@ proc doDownload*(url: string, downloadDir: string, verRange: VersionRange,
if verRange.spe == newSpecial(getHeadName(downMethod)): if verRange.spe == newSpecial(getHeadName(downMethod)):
doClone(downMethod, url, downloadDir) # Grab HEAD. doClone(downMethod, url, downloadDir) # Grab HEAD.
else: else:
# Mercurial requies a clone and checkout. The git clone operation is # Grab the full repo.
# already fragmented into multiple steps so we just call doClone().
if downMethod == DownloadMethod.git:
doClone(downMethod, url, downloadDir, $verRange.spe)
else:
doClone(downMethod, url, downloadDir, tip = false) doClone(downMethod, url, downloadDir, tip = false)
# Then perform a checkout operation to get the specified branch/commit.
doCheckout(downMethod, downloadDir, $verRange.spe) doCheckout(downMethod, downloadDir, $verRange.spe)
result = verRange result = verRange
else: else:

4
tests/tester.nim
View file

@ -22,6 +22,10 @@ proc inLines(lines: seq[string], line: string): bool =
for i in lines: for i in lines:
if line.normalize in i.normalize: return true if line.normalize in i.normalize: return true
test "issue 129 (installing commit hash)":
check execCmdEx(path & " install -y \"https://github.com/nimble-test/packagea.git@#1f9cb289c89\"").
exitCode == QuitSuccess
test "issue 113 (uninstallation problems)": test "issue 113 (uninstallation problems)":
cd "issue113/c": cd "issue113/c":
check execCmdEx("../../" & path & " install -y").exitCode == QuitSuccess check execCmdEx("../../" & path & " install -y").exitCode == QuitSuccess