Terminate copy iteration when hitting in-place nimbleDir (#429)

* terminate copy iteration when hitting in-place nimbleDir; fixes #428

* investigate travis issue

* more investigations

* more investigations

* fix nim version issue

src/nimblepkg/packageinfo.nim

@@ -510,13 +510,13 @@ proc iterInstallFiles*(realDir: string, pkgInfo: PackageInfo,
     for kind, file in walkDir(realDir):
       if kind == pcDir:
         let skip = pkgInfo.checkInstallDir(realDir, file)
-
         if skip: continue
+        # we also have to stop recursing if we reach an in-place nimbleDir
+        if file == options.getNimbleDir().expandFilename(): continue
 
         iterInstallFiles(file, pkgInfo, options, action)
       else:
         let skip = pkgInfo.checkInstallFile(realDir, file)
-
         if skip: continue
 
         action(file)

tests/issue428/dummy.nimble

@@ -0,0 +1,10 @@
+# Package
+
+version       = "0.1.0"
+author        = "Author"
+description   = "dummy"
+license       = "MIT"
+
+# Dependencies
+
+requires "nim >= 0.17.0"

tests/tester.nim

@@ -354,6 +354,13 @@ test "issue #338":
   cd "issue338":
     check execNimble("install", "-y").exitCode == QuitSuccess
 
+test "issue #428":
+  cd "issue428":
+    # Note: Can't use execNimble because it patches nimbleDir
+    check execCmdEx(nimblePath & " -y --nimbleDir=./nimbleDir install").exitCode == QuitSuccess
+    check dirExists("nimbleDir/pkgs/dummy-0.1.0")
+    check(not dirExists("nimbleDir/pkgs/dummy-0.1.0/nimbleDir"))
+
 test "can list":
   check execNimble("list").exitCode == QuitSuccess