From 2de92a8230b296e33fbfde51d2167b4aadff5631 Mon Sep 17 00:00:00 2001 From: Yuriy Glukhov Date: Sun, 14 Feb 2016 21:13:02 +0200 Subject: [PATCH 1/2] Fixes symlink installation issue --- src/nimble.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nimble.nim b/src/nimble.nim index f649d35..968e958 100644 --- a/src/nimble.nim +++ b/src/nimble.nim @@ -413,7 +413,7 @@ proc installFromDir(dir: string, latest: bool, options: Options, when defined(unix): # TODO: Verify that we are removing an old bin of this package, not # some other package's binary! - if existsFile(binDir / bin): removeFile(binDir / cleanBin) + if existsFile(binDir / cleanBin): removeFile(binDir / cleanBin) echo("Creating symlink: ", pkgDestDir / bin, " -> ", binDir / cleanBin) createSymlink(pkgDestDir / bin, binDir / cleanBin) elif defined(windows): From 2fdc267ba7b8d729158bf06f954c587a480f3bd1 Mon Sep 17 00:00:00 2001 From: Yuriy Glukhov Date: Mon, 15 Feb 2016 11:57:50 +0200 Subject: [PATCH 2/2] Added test for #206 --- tests/issue206/issue/issue206bin.nim | 2 ++ tests/issue206/issue206.nimble | 10 ++++++++++ tests/tester.nim | 7 +++++++ 3 files changed, 19 insertions(+) create mode 100644 tests/issue206/issue/issue206bin.nim create mode 100644 tests/issue206/issue206.nimble diff --git a/tests/issue206/issue/issue206bin.nim b/tests/issue206/issue/issue206bin.nim new file mode 100644 index 0000000..1726a88 --- /dev/null +++ b/tests/issue206/issue/issue206bin.nim @@ -0,0 +1,2 @@ + +echo "Hello" diff --git a/tests/issue206/issue206.nimble b/tests/issue206/issue206.nimble new file mode 100644 index 0000000..1daea5c --- /dev/null +++ b/tests/issue206/issue206.nimble @@ -0,0 +1,10 @@ +# Package +version = "0.1.0" +author = "Yuriy Glukhov" +description = "Test package for Issue 206" +license = "BSD" + +bin = @["issue/issue206bin"] + +# Dependencies +requires "nimrod >= 0.9.3" diff --git a/tests/tester.nim b/tests/tester.nim index eb73db5..886533b 100644 --- a/tests/tester.nim +++ b/tests/tester.nim @@ -179,6 +179,13 @@ test "issue #108": check exitCode != QuitSuccess check "Nothing to build" in lines[^1] +test "issue #206": + cd "issue206": + var (output, exitCode) = execCmdEx("../" & path & " install -y") + check exitCode == QuitSuccess + (output, exitCode) = execCmdEx("../" & path & " install -y") + check exitCode == QuitSuccess + test "can list": check execCmdEx(path & " list").exitCode == QuitSuccess