Merge remote-tracking branch 'upstream/master'

Conflicts:
	src/nimble.nim

src/nimblepkg/download.nim

@@ -146,7 +146,7 @@ proc checkUrlType*(url: string): DownloadMethod =
 proc isURL*(name: string): bool =
   name.startsWith(peg" @'://' ")
 
-proc doDownload*(url: string, downloadDir: string, verRange: VersionRangeRef,
+proc doDownload*(url: string, downloadDir: string, verRange: VersionRange,
                  downMethod: DownloadMethod) =
   template getLatestByTag(meth: stmt): stmt {.dirty, immediate.} =
     echo("Found tags...")

src/nimblepkg/packageinfo.nim

@@ -4,7 +4,7 @@ import parsecfg, json, streams, strutils, parseutils, os
 import version, tools, nimbletypes
 type
   ## Tuple containing package name and version range.
-  PkgTuple* = tuple[name: string, ver: VersionRangeRef]
+  PkgTuple* = tuple[name: string, ver: VersionRange]
 
   PackageInfo* = object
     mypath*: string ## The path of this .nimble file
@@ -95,7 +95,7 @@ proc parseRequires(req: string): PkgTuple =
       result.ver = parseVersionRange(req[i .. -1])
     else:
       result.name = req.strip
-      result.ver = VersionRangeRef(kind: verAny)
+      result.ver = VersionRange(kind: verAny)
   except ParseVersionError:
     raise newException(NimbleError,
         "Unable to parse dependency version range: " & getCurrentExceptionMsg())
@@ -351,7 +351,7 @@ proc echoPackage*(pkg: Package) =
   if pkg.web.len > 0:
     echo("  website:     " & pkg.web)
 
-proc getDownloadDirName*(pkg: Package, verRange: VersionRangeRef): string =
+proc getDownloadDirName*(pkg: Package, verRange: VersionRange): string =
   result = pkg.name
   let verSimple = getSimpleString(verRange)
   if verSimple != "":

src/nimblepkg/tools.nim

@@ -81,7 +81,7 @@ proc copyDirD*(fro, to: string): seq[string] =
     createDir(changeRoot(fro, to, path.splitFile.dir))
     result.add copyFileD(path, changeRoot(fro, to, path))
 
-proc getDownloadDirName*(uri: string, verRange: VersionRangeRef): string =
+proc getDownloadDirName*(uri: string, verRange: VersionRange): string =
   ## Creates a directory name based on the specified ``uri`` (url)
   result = ""
   let puri = parseUri(uri)

src/nimblepkg/version.nim

@@ -17,15 +17,15 @@ type
     verAny, # *
     verSpecial # #head
 
-  VersionRangeRef* = ref VersionRange
-  VersionRange* = object
+  VersionRange* = ref VersionRangeObj
+  VersionRangeObj = object
     case kind*: VersionRangeEnum
     of verLater, verEarlier, verEqLater, verEqEarlier, verEq:
       ver*: Version
     of verSpecial:
       spe*: Special
     of verIntersect:
-      verILeft, verIRight: VersionRangeRef
+      verILeft, verIRight: VersionRange
     of verAny:
       nil
 
@@ -80,7 +80,7 @@ proc `==`*(spe: Special, spe2: Special): bool =
 proc `<=`*(ver: Version, ver2: Version): bool =
   return (ver == ver2) or (ver < ver2)
 
-proc withinRange*(ver: Version, ran: VersionRangeRef): bool =
+proc withinRange*(ver: Version, ran: VersionRange): bool =
   case ran.kind
   of verLater:
     return ver > ran.ver
@@ -99,7 +99,7 @@ proc withinRange*(ver: Version, ran: VersionRangeRef): bool =
   of verAny:
     return true
 
-proc withinRange*(spe: Special, ran: VersionRangeRef): bool =
+proc withinRange*(spe: Special, ran: VersionRange): bool =
   case ran.kind
   of verLater, verEarlier, verEqLater, verEqEarlier, verEq, verIntersect:
     return false
@@ -108,13 +108,13 @@ proc withinRange*(spe: Special, ran: VersionRangeRef): bool =
   of verAny:
     return true
 
-proc contains*(ran: VersionRangeRef, ver: Version): bool =
+proc contains*(ran: VersionRange, ver: Version): bool =
   return withinRange(ver, ran)
 
-proc contains*(ran: VersionRangeRef, spe: Special): bool =
+proc contains*(ran: VersionRange, spe: Special): bool =
   return withinRange(spe, ran)
 
-proc makeRange*(version: string, op: string): VersionRangeRef =
+proc makeRange*(version: string, op: string): VersionRange =
   new(result)
   if version == "":
     raise newException(ParseVersionError,
@@ -134,7 +134,7 @@ proc makeRange*(version: string, op: string): VersionRangeRef =
     raise newException(ParseVersionError, "Invalid operator: " & op)
   result.ver = Version(version)
 
-proc parseVersionRange*(s: string): VersionRangeRef =
+proc parseVersionRange*(s: string): VersionRange =
   # >= 1.5 & <= 1.8
   new(result)
   if s[0] == '#':
@@ -184,7 +184,7 @@ proc parseVersionRange*(s: string): VersionRangeRef =
           "Unexpected char in version range: " & s[i])
     inc(i)
 
-proc `$`*(verRange: VersionRangeRef): string =
+proc `$`*(verRange: VersionRange): string =
   case verRange.kind
   of verLater:
     result = "> "
@@ -205,7 +205,7 @@ proc `$`*(verRange: VersionRangeRef): string =
 
   result.add(string(verRange.ver))
 
-proc getSimpleString*(verRange: VersionRangeRef): string =
+proc getSimpleString*(verRange: VersionRange): string =
   ## Gets a string with no special symbols and spaces. Used for dir name
   ## creation in tools.nim
   case verRange.kind
@@ -219,21 +219,21 @@ proc getSimpleString*(verRange: VersionRangeRef): string =
   of verAny:
     result = ""
 
-proc newVRAny*(): VersionRangeRef =
+proc newVRAny*(): VersionRange =
   new(result)
   result.kind = verAny
 
-proc newVREarlier*(ver: string): VersionRangeRef =
+proc newVREarlier*(ver: string): VersionRange =
   new(result)
   result.kind = verEarlier
   result.ver = newVersion(ver)
 
-proc newVREq*(ver: string): VersionRangeRef =
+proc newVREq*(ver: string): VersionRange =
   new(result)
   result.kind = verEq
   result.ver = newVersion(ver)
 
-proc findLatest*(verRange: VersionRangeRef,
+proc findLatest*(verRange: VersionRange,
         versions: Table[Version, string]): tuple[ver: Version, tag: string] =
   result = (newVersion(""), "")
   for ver, tag in versions: