jyapayne/packages
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #363 from def-/https-git

Browse source 
Use secure https instead of insecure git protocol
This commit is contained in:
Dominik Picheta 2016-06-10 00:48:48 +01:00 • committed by GitHub
commit c669bfe2e3
2 changed files with 168 additions and 163 deletions
Download patch file Download diff file Expand all files Collapse all files

7
package_scanner.nim
View file

@ -10,6 +10,7 @@
# * Missing tags # * Missing tags
# * Missing description # * Missing description
# * Missing/unknown license # * Missing/unknown license
# * Insecure git:// url on GitHub
# #
# Usage: nim c -d:ssl -r package_scanner.nim # Usage: nim c -d:ssl -r package_scanner.nim
# #
@ -101,7 +102,7 @@ proc check(): int =
echo "E: ", name, " has no URL" echo "E: ", name, " has no URL"
result.inc() result.inc()
elif not canFetchNimbleRepository(name, pdata["web"]): elif pdata.hasKey("web") and not canFetchNimbleRepository(name, pdata["web"]):
result.inc() result.inc()
elif not pdata.hasKey("tags"): elif not pdata.hasKey("tags"):
@ -116,6 +117,10 @@ proc check(): int =
echo "E: ", name, " has no license" echo "E: ", name, " has no license"
result.inc() result.inc()
elif pdata["url"].str.normalize.startsWith("git://github.com/"):
echo "E: ", name, " has an insecure git:// URL instead of https://"
result.inc()
else: else:
# Other warnings should go here # Other warnings should go here
if not (pdata["license"].str in LICENSES): if not (pdata["license"].str in LICENSES):

324
packages.json
View file

File diff suppressed because it is too large Load diff