Commit graph

7 commits

Author SHA1 Message Date
Danieth
486589d967 Modified jsonsHeaders#jsons2arrays to work with falsy keys
* `header in object` should be a sufficient condition. The suggested
  `String(object[header])` wasn't passing the original tests - it caused
  keys that didn't exist on the object to be inserted as
  undefined. Checking if the key is in the object allows for falsy
  values, while preventing keys that haven't ever been set from leaking
  in.
* Should close issue #6
* https://github.com/abdennour/react-csv/issues/6
2017-03-12 15:17:52 -04:00
quintezkiller
56ab83adcd Wrapping each element of the the row in quotes
Commas inside of an element were not supported as the element in the data source wasn't being wrapped in quotes. Wrapping the element in quotes before joining should resolve the problem.
2017-03-09 07:42:35 -05:00
abdennour
7918cadcd9 It resolves #3 2017-02-17 19:06:30 +03:00
abdennour
067281b7a3 coverage 🖼 100% of core.js
🌴 🌴
2016-11-26 02:11:41 +03:00
abdennour
f47d6ee7be 🎉 🎉 coverage of core testing reaches 80% 🌹 🍻 2016-11-25 18:21:23 +03:00
abdennour
05a02765d0 💫 still working 2016-11-25 16:48:16 +03:00
abdennour
41d2cd8b9c 🌎 🌍 🌏 initial commit 2016-11-25 15:59:50 +03:00