Change %extend example which said that char arrays were problematic to wrap, when in fact they are not

git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/trunk@11764 626c5289-ae23-0410-ae9c-e8d60b6d4f22

Doc/Manual/SWIG.html

@@ -2506,41 +2506,53 @@ of the object.
 </p>
 
 <p>
-A similar technique can also be used to work with problematic data members.
+A similar technique can also be used to work with data members that you want to process.
 For example, consider this interface:
 </p>
 
 <div class="code">
 <pre>
 typedef struct {
-   char name[50];
+  char name[50];
-   ...
+  ...
 } Person;
 </pre>
 </div>
 
 <p>
-By default, the <tt>name</tt> attribute is read-only because SWIG does not
+Say you wanted to ensure <tt>name</tt> was always upper case, you can rewrite
-normally know how to modify arrays.  However, you can rewrite the interface
+the interface as follows to ensure this occurs whenever a name is read or written to:
-as follows to change this:
 </p>
 
 <div class="code">
 <pre>
 typedef struct {
-    %extend {
+  %extend {
-       char *name;
+    char name[50];
-    }
+  }
-...
+  ...
 } Person;
 
-// Specific implementation of set/get functions
 %{
-char *Person_name_get(Person *p) {
+#include &lt;string.h&gt;
-   return p-&gt;name;
+#include &lt;ctype.h&gt;
+
+void make_upper(char *name) {
+  char *c;
+  for (c = name; *c; ++c)
+    *c = (char)toupper((int)*c);
 }
+
+/* Specific implementation of set/get functions forcing capitalization */
+
+char *Person_name_get(Person *p) {
+  make_upper(p-&gt;name);
+  return p-&gt;name;
+}
+
 void Person_name_set(Person *p, char *val) {
-   strncpy(p-&gt;name,val,50);
+  strncpy(p-&gt;name,val,50);
+  make_upper(p-&gt;name);
 }
 %}
 </pre>
@@ -2550,7 +2562,7 @@ void Person_name_set(Person *p, char *val) {
 Finally, it should be stressed that even though <tt>%extend</tt>
 can be used to add new data members, these new members can not require
 the allocation of additional storage in the object (e.g., their values must
-be entirely synthesized from existing attributes of the structure).
+be entirely synthesized from existing attributes of the structure or obtained elsewhere).
 </p>
 
 <p>
@@ -2633,7 +2645,7 @@ $o-&gt;{intRep}-&gt;{ivalue} = 7              # Change value of o.intRep.ivalue
 </pre></div>
 
 <p>
-If you have a lot nested structure declarations, it is
+If you have a lot of nested structure declarations, it is
 advisable to double-check them after running SWIG. Although,
 there is a good chance that they will work, you may have to
 modify the interface file in certain cases.

Examples/test-suite/memberin_extend.i

@@ -1,6 +1,6 @@
 %module memberin_extend
 
-// Tests memberin typemap. The default char * memberin typemap will be used.
+// Tests memberin typemap is not used for %extend.
 // The test extends the struct with a pseudo member variable
 
 %inline %{

Examples/test-suite/memberin_extend_c.i

@@ -4,22 +4,35 @@
 
 %{
 typedef struct {
-    char name[50];
+  char name[50];
 } Person;
 %}
 
 typedef struct {
-    %extend {
+  %extend {
-        char *name;
+    char name[50];
-    }
+  }
 } Person;
 
-/* Specific implementation of set/get functions */
 %{
-char *Person_name_get(Person *p) {
+#include <ctype.h>
-   return p->name;
+#include <string.h>
+
+void make_upper(char *name) {
+  char *c;
+  for (c = name; *c; ++c)
+    *c = (char)toupper((int)*c);
 }
+
+/* Specific implementation of set/get functions forcing capitalization */
+
+char *Person_name_get(Person *p) {
+  make_upper(p->name);
+  return p->name;
+}
+
 void Person_name_set(Person *p, char *val) {
-   strncpy(p->name,val,50);
+  strncpy(p->name,val,50);
+  make_upper(p->name);
 }
 %}

Examples/test-suite/python/memberin_extend_c_runme.py

@@ -1,6 +1,6 @@
 import memberin_extend_c
 
 t = memberin_extend_c.Person()
-t.name = "some name"
+t.name = "Fred Bloggs"
-if t.name != "some name":
+if t.name != "FRED BLOGGS":
-  raise RuntimeError("some name wrong")
+  raise RuntimeError("name wrong")