jyapayne/swig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replicate Python memory leak fix in std::pair for Octave and Ruby

Browse source 
https://github.com/swig/swig/pull/851
This commit is contained in:
William S Fulton 2016-12-18 19:53:20 +00:00
commit 364fa82499
4 changed files with 24 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
CHANGES.current
View file

@ -5,6 +5,10 @@ See the RELEASENOTES file for a summary of changes in each release.
Version 3.0.11 (in progress) Version 3.0.11 (in progress)
============================ ============================
2016-12-18: ezralanglois
[Python, Ruby, Octave] Memory leak fix on error in std::pair wrappers.
Issue https://github.com/swig/swig/pull/851
2016-12-16: bcaine 2016-12-16: bcaine
[Guile] Patch #744 Added support for Guile's native pointer functionality [Guile] Patch #744 Added support for Guile's native pointer functionality

8
Lib/octave/std_pair.i
View file

@ -69,12 +69,16 @@
value_type *vp = %new_instance(std::pair<T,U>); value_type *vp = %new_instance(std::pair<T,U>);
T *pfirst = &(vp->first); T *pfirst = &(vp->first);
int res1 = swig::asval(first, pfirst); int res1 = swig::asval(first, pfirst);
if (!SWIG_IsOK(res1)) if (!SWIG_IsOK(res1)) {
%delete(vp);
return res1; return res1;
}
U *psecond = &(vp->second); U *psecond = &(vp->second);
int res2 = swig::asval(second, psecond); int res2 = swig::asval(second, psecond);
if (!SWIG_IsOK(res2)) if (!SWIG_IsOK(res2)) {
%delete(vp);
return res2; return res2;
}
*val = vp; *val = vp;
return SWIG_AddNewMask(res1 > res2 ? res1 : res2); return SWIG_AddNewMask(res1 > res2 ? res1 : res2);
} else { } else {

10
Lib/python/std_pair.i
View file

@ -31,7 +31,7 @@
int res2 = swig::asval((PyObject*)second, psecond); int res2 = swig::asval((PyObject*)second, psecond);
if (!SWIG_IsOK(res2)) return res2; if (!SWIG_IsOK(res2)) return res2;
return res1 > res2 ? res1 : res2; return res1 > res2 ? res1 : res2;
} }
} }
static int asval(PyObject *obj, std::pair<T,U> *val) { static int asval(PyObject *obj, std::pair<T,U> *val) {
@ -68,15 +68,13 @@
value_type *vp = %new_instance(std::pair<T,U>); value_type *vp = %new_instance(std::pair<T,U>);
T *pfirst = &(vp->first); T *pfirst = &(vp->first);
int res1 = swig::asval((PyObject*)first, pfirst); int res1 = swig::asval((PyObject*)first, pfirst);
if (!SWIG_IsOK(res1)) if (!SWIG_IsOK(res1)) {
{
%delete(vp); %delete(vp);
return res1; return res1;
} }
U *psecond = &(vp->second); U *psecond = &(vp->second);
int res2 = swig::asval((PyObject*)second, psecond); int res2 = swig::asval((PyObject*)second, psecond);
if (!SWIG_IsOK(res2)) if (!SWIG_IsOK(res2)) {
{
%delete(vp); %delete(vp);
return res2; return res2;
} }
@ -90,7 +88,7 @@
int res2 = swig::asval((PyObject*)second, psecond); int res2 = swig::asval((PyObject*)second, psecond);
if (!SWIG_IsOK(res2)) return res2; if (!SWIG_IsOK(res2)) return res2;
return res1 > res2 ? res1 : res2; return res1 > res2 ? res1 : res2;
} }
} }
static int asptr(PyObject *obj, std::pair<T,U> **val) { static int asptr(PyObject *obj, std::pair<T,U> **val) {

14
Lib/ruby/std_pair.i
View file

@ -31,7 +31,7 @@
int res2 = swig::asval((VALUE)second, psecond); int res2 = swig::asval((VALUE)second, psecond);
if (!SWIG_IsOK(res2)) return res2; if (!SWIG_IsOK(res2)) return res2;
return res1 > res2 ? res1 : res2; return res1 > res2 ? res1 : res2;
} }
} }
static int asval(VALUE obj, std::pair<T,U> *val) { static int asval(VALUE obj, std::pair<T,U> *val) {
@ -63,10 +63,16 @@
value_type *vp = %new_instance(std::pair<T,U>); value_type *vp = %new_instance(std::pair<T,U>);
T *pfirst = &(vp->first); T *pfirst = &(vp->first);
int res1 = swig::asval((VALUE)first, pfirst); int res1 = swig::asval((VALUE)first, pfirst);
if (!SWIG_IsOK(res1)) return res1; if (!SWIG_IsOK(res1)) {
%delete(vp);
return res1;
}
U *psecond = &(vp->second); U *psecond = &(vp->second);
int res2 = swig::asval((VALUE)second, psecond); int res2 = swig::asval((VALUE)second, psecond);
if (!SWIG_IsOK(res2)) return res2; if (!SWIG_IsOK(res2)) {
%delete(vp);
return res2;
}
*val = vp; *val = vp;
return SWIG_AddNewMask(res1 > res2 ? res1 : res2); return SWIG_AddNewMask(res1 > res2 ? res1 : res2);
} else { } else {
@ -77,7 +83,7 @@
int res2 = swig::asval((VALUE)second, psecond); int res2 = swig::asval((VALUE)second, psecond);
if (!SWIG_IsOK(res2)) return res2; if (!SWIG_IsOK(res2)) return res2;
return res1 > res2 ? res1 : res2; return res1 > res2 ? res1 : res2;
} }
} }
static int asptr(VALUE obj, std::pair<T,U> **val) { static int asptr(VALUE obj, std::pair<T,U> **val) {