From 3a84a4dd96d320cbbaa9d51bf5ebea94dc0ef6fb Mon Sep 17 00:00:00 2001
From: Olly Betts <olly@survex.com>
Date: Sun, 12 Jun 2022 10:19:15 +1200
Subject: [PATCH] [php] Fix new default_args_runme.php for PHP < 7.3

---
 .../test-suite/php/default_args_runme.php     | 34 ++++++++++++-------
 1 file changed, 22 insertions(+), 12 deletions(-)

diff --git a/Examples/test-suite/php/default_args_runme.php b/Examples/test-suite/php/default_args_runme.php
index 944426e29..3e3f2f31a 100644
--- a/Examples/test-suite/php/default_args_runme.php
+++ b/Examples/test-suite/php/default_args_runme.php
@@ -42,39 +42,49 @@ check::equal($f->double_if_void_ptr_is_null(6, Null), 12, "\$f->double_if_void_p
 
 check::equal($f->double_if_void_ptr_is_null(7), 14, "\$f->double_if_void_ptr_is_null(7)");
 
+# For the testcases below PHP < 7.3 emits an error, while newer versions throw
+# an exception.  We handle the older versions by suppressing the error with `@`,
+# then checking for the created object being Null if the PHP version is < 7.3.
+
 try {
-    $f = new Foo(1);
-    check::fail("Foo::Foo ignore is not working");
+    @$f = new Foo(1);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::Foo ignore is not working");
 } catch (ArgumentCountError $e) {
 }
 
 try {
-    $f = new Foo(1, 2);
-    check::fail("Foo::Foo ignore is not working");
+    @$f = new Foo(1, 2);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::Foo ignore is not working");
 } catch (ArgumentCountError $e) {
 }
 
 try {
-    $f = new Foo(1, 2, 3);
-    check::fail("Foo::Foo ignore is not working");
+    @$f = new Foo(1, 2, 3);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::Foo ignore is not working");
 } catch (ArgumentCountError $e) {
 }
 
 try {
-    $m = $f->meth(1);
-    check::fail("Foo::meth ignore is not working");
+    @$m = $f->meth(1);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::meth ignore is not working");
 } catch (Error $e) {
 }
 
 try {
-    $m = $f->meth(1, 2);
-    check::fail("Foo::meth ignore is not working");
+    @$m = $f->meth(1, 2);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::meth ignore is not working");
 } catch (Error $e) {
 }
 
 try {
-    $m = $f->meth(1, 2, 3);
-    check::fail("Foo::meth ignore is not working");
+    @$m = $f->meth(1, 2, 3);
+    if (!(PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION < 3 && $f === null))
+      check::fail("Foo::meth ignore is not working");
 } catch (Error $e) {
 }