jyapayne/swig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix in typemap for void** and void*&

Browse source 
Mark the parameter as "byref" and write back through the reference
after the call.

Adjust testcase argout to uncomment the part that's meant to test this,
and to remove lingering traces of PHP's old call-time pass-by-reference
(which was completely removed before PHP 7).

Fixes #1457
This commit is contained in:
Olly Betts 2021-04-14 17:05:19 +12:00
commit 451998f27b
2 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Examples/test-suite/php/argout_runme.php
View file

@ -22,16 +22,10 @@ check::equal(4,inctr($tr),"4==incr($tr)");
check::equal(5,intp_value($tr),"5==$tr");
# Check the voidhandle call, first with null
unset($handle);
# FIXME: Call-time pass-by-reference has been deprecated for ages, and was
# removed in PHP 5.4. We need to rework
#voidhandle(&$handle);
#check::resource($handle,"_p_void",'$handle is not _p_void');
#$handledata=handle($handle);
#check::equal($handledata,"Here it is","\$handledata != \"Here it is\"");
$handle=NULL;
voidhandle($handle);
check::isnull($handle,'$handle not null');
check::resource($handle,"_p_void",'$handle is not _p_void');
$handledata=handle($handle);
check::equal($handledata,"Here it is","\$handledata != \"Here it is\"");
check::done();