From 89fd7ed9c1b1c1e0a1a5344018ab9d0a5ce711b0 Mon Sep 17 00:00:00 2001 From: Vladimir Menshakov Date: Sat, 14 Sep 2013 16:17:21 +0400 Subject: [PATCH 1/2] fixed newer v8 compilation --- Lib/javascript/v8/javascriptrun.swg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/javascript/v8/javascriptrun.swg b/Lib/javascript/v8/javascriptrun.swg index bab81613c..fbdb75c3a 100644 --- a/Lib/javascript/v8/javascriptrun.swg +++ b/Lib/javascript/v8/javascriptrun.swg @@ -392,7 +392,7 @@ void _wrap_SwigV8PackedData_delete(v8::Persistent< v8::Value > object, void *par { SwigV8PackedData *cdata = static_cast(parameter); #else -void _wrap_SwigV8PackedData_delete(v8::Isolate *isolate, v8::Persistent< v8::Object > * object, SwigV8PackedData *proxy) +void _wrap_SwigV8PackedData_delete(v8::Isolate *isolate, v8::Persistent< v8::Object > * object, SwigV8PackedData *cdata) { #endif From 325b5445d67ccf60855aac970ecb6ba913e2b32b Mon Sep 17 00:00:00 2001 From: Vladimir Menshakov Date: Sat, 14 Sep 2013 16:19:47 +0400 Subject: [PATCH 2/2] removed Clear before Dispose from newer v8 code, consider the following code: template void Persistent::Dispose() { if (this->IsEmpty()) return; //Clear will trigger this V8::DisposeGlobal(reinterpret_cast(this->val_)); ... } --- Lib/javascript/v8/javascriptrun.swg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/javascript/v8/javascriptrun.swg b/Lib/javascript/v8/javascriptrun.swg index fbdb75c3a..5be16add5 100644 --- a/Lib/javascript/v8/javascriptrun.swg +++ b/Lib/javascript/v8/javascriptrun.swg @@ -398,8 +398,8 @@ void _wrap_SwigV8PackedData_delete(v8::Isolate *isolate, v8::Persistent< v8::Obj delete cdata; - object.Clear(); #if (SWIG_V8_VERSION < 0x031900) + object.Clear(); object.Dispose(); #elif (SWIG_V8_VERSION < 0x032100) object->Dispose(isolate);