don't use Py_None directly nor &PyType_Type

git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/trunk/SWIG@7925 626c5289-ae23-0410-ae9c-e8d60b6d4f22

Examples/test-suite/python/input.i

@@ -6,8 +6,7 @@
   if ($1) {
     $result = SWIG_From(int)(*$1);
   } else {
-    Py_INCREF(Py_None);
+    $result = SWIG_Py_Void();
-    $result = Py_None;
   }
 }
 
@@ -30,8 +29,7 @@
   if ($1) {
     $result = SWIG_From(std::string)(*$1);
   } else {
-    Py_INCREF(Py_None);
+    $result = SWIG_Py_Void();
-    $result = Py_None;
   }
 }
 

Lib/python/pyapi.swg

@@ -4,6 +4,9 @@
 
 #ifdef __cplusplus
 extern "C" {
+#if 0
+} /* cc-mode */
+#endif
 #endif
 
 /* -----------------------------------------------------------------------------
@@ -16,16 +19,40 @@ extern "C" {
 
 /* Constant information structure */
 typedef struct swig_const_info {
-    int type;
+  int type;
-    char *name;
+  char *name;
-    long lvalue;
+  long lvalue;
-    double dvalue;
+  double dvalue;
-    void   *pvalue;
+  void   *pvalue;
-    swig_type_info **ptype;
+  swig_type_info **ptype;
 } swig_const_info;
 
 
 
+/* -----------------------------------------------------------------------------
+ * Safe Py_None and Py_Void accessors
+ * ----------------------------------------------------------------------------- */
+
+SWIGRUNTIME PyObject * 
+SWIG_Py_None(void)
+{
+  static PyObject *none = 0;
+  if (!none) {
+    none = Py_BuildValue("");
+    Py_DECREF(none);
+  }
+  return none;
+}
+
+SWIGRUNTIMEINLINE PyObject * 
+SWIG_Py_Void(void)
+{
+  PyObject *none = SWIG_Py_None();
+  Py_INCREF(none);
+  return none;
+}
+
+
 /* -----------------------------------------------------------------------------
  * Append a value to the result obj
  * ----------------------------------------------------------------------------- */
@@ -33,7 +60,7 @@ SWIGINTERN PyObject*
 SWIG_Python_AppendOutput(PyObject* result, PyObject* obj) {
   if (!result) {
     result = obj;
-  } else if (result == Py_None) {  
+  } else if (result == SWIG_Py_None()) {
     Py_DECREF(result);
     result = obj;
   } else {
@@ -49,6 +76,9 @@ SWIG_Python_AppendOutput(PyObject* result, PyObject* obj) {
 }
 
 #ifdef __cplusplus
+#if 0
+{ /* cc-mode */
+#endif
 }
 #endif
 

Lib/python/pycontainer.swg

@@ -262,8 +262,7 @@ namespace swig
 {
   %ignore stop_iteration;
   %typemap(throws) stop_iteration {
-    Py_INCREF(Py_None);
+    PyErr_SetObject(PyExc_StopIteration, SWIG_Py_Void());
-    PyErr_SetObject(PyExc_StopIteration, Py_None);
   }
 }
 

Lib/python/pyinit.swg

@@ -96,7 +96,7 @@ swig_varlink_type(void) {
     const PyTypeObject tmp
 #endif
       = {
-      PyObject_HEAD_INIT(&PyType_Type)
+      PyObject_HEAD_INIT(NULL)
       0,                                  /* Number of items in variable part (ob_size) */
       (char *)"swigvarlink",              /* Type name (tp_name) */
       sizeof(swig_varlinkobject),         /* Basic size (tp_basicsize) */
@@ -137,6 +137,7 @@ swig_varlink_type(void) {
     type_init = 1;
   }
 #endif
+  varlink_type.ob_type = &PyType_Type;
   return &varlink_type;
 }
 

Lib/python/pyrun.swg

@@ -262,24 +262,24 @@ SWIGRUNTIME PyObject*
 PySwigObject_append(PyObject* v, PyObject* next)
 {
   PySwigObject *sobj = (PySwigObject *) v;
-  if (!PySwigObject_Check(next)) 
+  if (!PySwigObject_Check(next)) {
     return NULL;
-  
+  }
   sobj->next = next;
   Py_INCREF(next);
-
+  return SWIG_Py_Void();
-  Py_INCREF(Py_None);
-  return Py_None;
 }
 
 SWIGRUNTIME PyObject* 
 PySwigObject_next(PyObject* v)
 {
   PySwigObject *sobj = (PySwigObject *) v;
-  PyObject *obj = sobj->next ? sobj->next : Py_None;
+  if (sobj->next) {    
-
+    Py_INCREF(sobj->next);
-  Py_INCREF(obj);
+    return sobj->next;
-  return obj;
+  } else {
+    return  SWIG_Py_Void();
+  }
 }
 
 SWIGINTERN PyObject*
@@ -287,8 +287,7 @@ PySwigObject_disown(PyObject *v)
 {
   PySwigObject *sobj = (PySwigObject *)v;
   sobj->own = 0;
-  Py_INCREF(Py_None);
+  return SWIG_Py_Void();
-  return Py_None;
 }
 
 SWIGINTERN PyObject*
@@ -296,8 +295,7 @@ PySwigObject_acquire(PyObject *v)
 {
   PySwigObject *sobj = (PySwigObject *)v;
   sobj->own = SWIG_POINTER_OWN;
-  Py_INCREF(Py_None);
+  return SWIG_Py_Void();
-  return Py_None;
 }
 
 SWIGINTERN PyObject*
@@ -373,7 +371,7 @@ PySwigObject_type(void) {
     const PyTypeObject tmp
 #endif
       = {
-	PyObject_HEAD_INIT(&PyType_Type)
+	PyObject_HEAD_INIT(NULL)
 	0,				    /* ob_size */
 	(char *)"PySwigObject",		    /* tp_name */
 	sizeof(PySwigObject),		    /* tp_basicsize */
@@ -433,6 +431,7 @@ PySwigObject_type(void) {
     type_init = 1;
   }
 #endif
+  pyswigobject_type.ob_type = &PyType_Type;
   return &pyswigobject_type;
 }
 
@@ -702,8 +701,8 @@ SWIG_Python_AcquirePtr(PyObject *obj, int own) {
 SWIGRUNTIME int
 SWIG_Python_ConvertPtrAndOwn(PyObject *obj, void **ptr, swig_type_info *ty, int flags, int *own) {
   if (!obj) return SWIG_ERROR;
-  if (obj == Py_None) {
+  if (obj == SWIG_Py_None()) {
-    *ptr = 0;
+    if (ptr) *ptr = 0;
     return SWIG_OK;
   } else {
     PySwigObject *sobj = SWIG_Python_GetSwigThis(obj);
@@ -713,7 +712,7 @@ SWIG_Python_ConvertPtrAndOwn(PyObject *obj, void **ptr, swig_type_info *ty, int
 	swig_type_info *to = sobj->ty;
 	if (to == ty) {
 	  /* no type cast needed */
-	  *ptr = vptr;
+	  if (ptr) *ptr = vptr;
 	  break;
 	} else {
 	  swig_cast_info *tc = SWIG_TypeCheck(to->name,ty);
@@ -725,7 +724,7 @@ SWIG_Python_ConvertPtrAndOwn(PyObject *obj, void **ptr, swig_type_info *ty, int
 	  }
 	}
       } else {
-	*ptr = vptr;
+	if (ptr) *ptr = vptr;
 	break;
       }
     }
@@ -834,8 +833,7 @@ SWIG_Python_NewShadowInstance(PySwigClientData *data, PyObject *swig_this)
 SWIGRUNTIME PyObject *
 SWIG_Python_NewPointerObj(void *ptr, swig_type_info *type, int flags) {
   if (!ptr) {
-    Py_INCREF(Py_None);
+    return SWIG_Py_Void();
-    return Py_None;
   } else if (!type) {
     if (!PyErr_Occurred()) {
       PyErr_SetString(PyExc_TypeError, "Swig: null type passed to NewPointerObj");
@@ -862,10 +860,8 @@ SWIGRUNTIME PyObject *
 SWIG_Python_NewPackedObj(void *ptr, size_t sz, swig_type_info *type) {
   PyObject *robj = 0;
   if (!ptr) {
-    Py_INCREF(Py_None);
+    return SWIG_Py_Void();
-    return Py_None;
   }
-
   robj = PySwigPacked_New((void *) ptr, sz, type);
   return robj;
 }

Lib/python/pystrings.swg

@@ -66,8 +66,7 @@ SWIG_FromCharPtrAndSize(const char* carray, size_t size)
       return PyString_FromStringAndSize(carray, %numeric_cast(size,int));
     }
   } else {
-    Py_INCREF(Py_None);
+    return SWIG_Py_Void();
-    return Py_None;
   }
 }
 }

Lib/python/pytypemaps.swg

@@ -39,7 +39,7 @@
 
 /* Python types */
 #define SWIG_Object                     PyObject *
-#define VOID_Object                     (Py_INCREF(Py_None) ? Py_None : 0)
+#define VOID_Object                     SWIG_Py_Void()
 
 /* Overload of the output/constant/exception/dirout handling */
 

Lib/python/pywstrings.swg

@@ -51,8 +51,7 @@ SWIG_FromWCharPtrAndSize(const wchar_t * carray, size_t size)
       return PyUnicode_FromWideChar(carray, %numeric_cast(size,int));
     }
   } else {
-    Py_INCREF(Py_None);
+    return SWIG_Py_Void();
-    return Py_None;
   }
 }
 }

Source/Modules/python.cxx

@@ -237,7 +237,7 @@ public:
     }
 
     /* Set comparison with none for ConstructorToFunction */
-    setSubclassInstanceCheck(NewString("$arg != Py_None"));
+    setSubclassInstanceCheck(NewString("$arg != SWIG_Py_None()"));
 
     /* Initialize all of the output files */
     String *outfile = Getattr(n,"outfile");
@@ -1438,7 +1438,7 @@ public:
     /*
     if (constructor && (Getattr(n, "wrap:self") != 0)) {
       Wrapper_add_local(f, "subclassed", "int subclassed = 0");
-      Printf(f->code, "subclassed = (arg1 != Py_None);\n");
+      Printf(f->code, "subclassed = (arg1 != SWIG_Py_None());\n");
     }
     */
      
@@ -2145,8 +2145,7 @@ public:
 	       tab4, "PyObject *obj;\n",
 	       tab4, "if (!PyArg_UnpackTuple(args,(char*)\"swigregister\", 1, 1,&obj)) return NULL;\n",
 	       tab4, "SWIG_TypeNewClientData(SWIGTYPE", SwigType_manglestr(ct),", SWIG_NewClientData(obj));\n",
-	       tab4, "Py_INCREF(Py_None);\n",
+	       tab4, "return SWIG_Py_Void();\n",
-	       tab4, "return Py_None;\n",
 	       "}\n",NIL);
 	String *cname = NewStringf("%s_swigregister", class_name);
 	add_method(cname, cname, 0);