From 9e83d5d5d9c65234f461c0cb6e04e4c9641b53dd Mon Sep 17 00:00:00 2001 From: William S Fulton Date: Tue, 4 Dec 2018 06:49:55 +0000 Subject: [PATCH] Fix nstest.py test Use subprocess.check_call as os.system won't stop the test in case of errors. --- .../python/import_packages/namespace_pkg/nstest.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Examples/python/import_packages/namespace_pkg/nstest.py b/Examples/python/import_packages/namespace_pkg/nstest.py index 9b075ad8c..b0b146c92 100644 --- a/Examples/python/import_packages/namespace_pkg/nstest.py +++ b/Examples/python/import_packages/namespace_pkg/nstest.py @@ -1,6 +1,7 @@ import sys import os import shutil +import subprocess import zipfile @@ -17,10 +18,10 @@ def copyMods(): os.mkdir(os.path.join(d, 'brave')) shutil.copy('robin.py', os.path.join('path1', 'brave')) - os.system('cp _robin.* ' + os.path.join('path1', 'brave')) + subprocess.check_call('cp _robin.* ' + os.path.join('path1', 'brave'), shell=True) shutil.copy('robin.py', os.path.join('path2', 'brave')) - os.system('cp _robin.* ' + os.path.join('path3', 'brave')) + subprocess.check_call('cp _robin.* ' + os.path.join('path3', 'brave'), shell=True) mkzip() @@ -35,10 +36,10 @@ def main(): copyMods() # Run each test with a separate interpreter - os.system(sys.executable + " nonpkg.py") - os.system(sys.executable + " normal.py") - os.system(sys.executable + " split.py") - os.system(sys.executable + " zipsplit.py") + subprocess.check_call(sys.executable + " nonpkg.py", shell=True) + subprocess.check_call(sys.executable + " normal.py", shell=True) + subprocess.check_call(sys.executable + " split.py", shell=True) + subprocess.check_call(sys.executable + " zipsplit.py", shell=True) if __name__ == "__main__":