jyapayne/swig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid unnecessary allocation in get_wrapper_func_return_type()

Browse source 
Don't call NewString() just to overwrite it with another pointer (and leak the
one allocated by NewString()).
This commit is contained in:
Vadim Zeitlin 2016-04-26 19:41:41 +02:00
commit ad5de803b5
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Source/Modules/c.cxx
View file

@ -743,7 +743,7 @@ ready:
String *get_wrapper_func_return_type(output_target target, Node *n) String *get_wrapper_func_return_type(output_target target, Node *n)
{ {
SwigType *type = Getattr(n, "type"); SwigType *type = Getattr(n, "type");
String *return_type = NewString(""); String *return_type;
String *tm; String *tm;
if ((tm = Swig_typemap_lookup("ctype", n, "", 0))) { if ((tm = Swig_typemap_lookup("ctype", n, "", 0))) {
@ -752,6 +752,7 @@ ready:
} }
else { else {
Swig_warning(WARN_C_TYPEMAP_CTYPE_UNDEF, input_file, line_number, "No ctype typemap defined for %s\n", SwigType_str(type, 0)); Swig_warning(WARN_C_TYPEMAP_CTYPE_UNDEF, input_file, line_number, "No ctype typemap defined for %s\n", SwigType_str(type, 0));
return_type = NewString("");
} }
Replaceall(return_type, "::", "_"); Replaceall(return_type, "::", "_");