Merge pull request #1668 from treitmayr/master

Fix code generated for Ruby global variables
This commit is contained in:
William S Fulton 2019-12-30 23:49:04 +00:00 • committed by GitHub
commit d53a54b4f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 342 additions and 10 deletions

View file

@ -250,6 +250,7 @@ CPP_TEST_CASES += \
funcptr_cpp \
functors \
fvirtual \
global_immutable_vars_cpp \
global_namespace \
global_ns_arg \
global_scope_types \
@ -692,6 +693,7 @@ C_TEST_CASES += \
funcptr \
function_typedef \
global_functions \
global_immutable_vars \
immutable_values \
inctest \
infinity \

View file

@ -0,0 +1,24 @@
%module global_immutable_vars
// Test immutable and mutable global variables,
// see http://www.swig.org/Doc4.0/SWIGDocumentation.html#SWIG_readonly_variables
%inline %{
int default_mutable_var = 40;
%}
%immutable;
%feature("immutable", "0") specific_mutable_var;
%inline %{
int global_immutable_var = 41;
int specific_mutable_var = 42;
%}
%mutable;
%immutable specific_immutable_var;
%inline %{
int global_mutable_var = 43;
int specific_immutable_var = 44;
%}

View file

@ -0,0 +1,24 @@
%module global_immutable_vars_cpp
// Test immutable and mutable global variables,
// see http://www.swig.org/Doc4.0/SWIGDocumentation.html#SWIG_readonly_variables
%inline %{
int default_mutable_var = 40;
%}
%immutable;
%feature("immutable", "0") specific_mutable_var;
%inline %{
int global_immutable_var = 41;
int specific_mutable_var = 42;
%}
%mutable;
%immutable specific_immutable_var;
%inline %{
int global_mutable_var = 43;
int specific_immutable_var = 44;
%}

View file

@ -23,6 +23,7 @@ CPP_TEST_CASES = \
li_std_wstring_inherit \
primitive_types \
ruby_alias_method \
ruby_global_immutable_vars_cpp \
ruby_keywords \
ruby_minherit_shared_ptr \
ruby_naming \
@ -48,6 +49,7 @@ C_TEST_CASES += \
li_cstring \
ruby_alias_global_function \
ruby_alias_module_function \
ruby_global_immutable_vars \
ruby_manual_proxy \
include $(srcdir)/../common.mk
@ -57,6 +59,8 @@ SWIGOPT += -w801 -noautorename -features autodoc=4
# Custom tests - tests with additional commandline options
ruby_alias_global_function.ctest: SWIGOPT += -globalmodule
ruby_global_immutable_vars.ctest: SWIGOPT += -globalmodule
ruby_global_immutable_vars_cpp.cpptest: SWIGOPT += -globalmodule
ruby_naming.cpptest: SWIGOPT += -autorename
# Rules for the different types of tests

View file

@ -0,0 +1,47 @@
#!/usr/bin/env ruby
#
# C++ version of global_immutable_vars_runme.rb
#
require 'swig_assert'
require 'global_immutable_vars_cpp'
# first check if all variables can be read
swig_assert_each_line( <<EOF )
Global_immutable_vars_cpp::default_mutable_var == 40
Global_immutable_vars_cpp::global_immutable_var == 41
Global_immutable_vars_cpp::specific_mutable_var == 42
Global_immutable_vars_cpp::global_mutable_var == 43
Global_immutable_vars_cpp::specific_immutable_var == 44
EOF
# check that all mutable variables can be modified
swig_assert_each_line( <<EOF )
Global_immutable_vars_cpp::default_mutable_var = 80
Global_immutable_vars_cpp::default_mutable_var == 80
Global_immutable_vars_cpp::specific_mutable_var = 82
Global_immutable_vars_cpp::specific_mutable_var == 82
Global_immutable_vars_cpp::global_mutable_var = 83
Global_immutable_vars_cpp::global_mutable_var == 83
EOF
# now check that immutable variables cannot be modified
had_exception = false
begin
Global_immutable_vars_cpp::global_immutable_var = 81
rescue NoMethodError => e
had_exception = true
end
swig_assert(had_exception, nil,
"Global_immutable_vars_cpp::global_immutable_var is writable (expected to be immutable)")
had_exception = false
begin
Global_immutable_vars_cpp::specific_immutable_var = 81
rescue NoMethodError => e
had_exception = true
end
swig_assert(had_exception, nil,
"Global_immutable_vars_cpp::specific_immutable_var is writable (expected to be immutable)")

View file

@ -0,0 +1,51 @@
#!/usr/bin/env ruby
#
# Here the proper generation of mutable and immutable variables is tested
# in the target language.
# Immutable variables do not have "<var>=" methods generated by SWIG,
# therefore trying to assign these variables shall throw a NoMethodError
# exception.
#
require 'swig_assert'
require 'global_immutable_vars'
# first check if all variables can be read
swig_assert_each_line( <<EOF )
Global_immutable_vars::default_mutable_var == 40
Global_immutable_vars::global_immutable_var == 41
Global_immutable_vars::specific_mutable_var == 42
Global_immutable_vars::global_mutable_var == 43
Global_immutable_vars::specific_immutable_var == 44
EOF
# check that all mutable variables can be modified
swig_assert_each_line( <<EOF )
Global_immutable_vars::default_mutable_var = 80
Global_immutable_vars::default_mutable_var == 80
Global_immutable_vars::specific_mutable_var = 82
Global_immutable_vars::specific_mutable_var == 82
Global_immutable_vars::global_mutable_var = 83
Global_immutable_vars::global_mutable_var == 83
EOF
# now check that immutable variables cannot be modified
had_exception = false
begin
Global_immutable_vars::global_immutable_var = 81
rescue NoMethodError => e
had_exception = true
end
swig_assert(had_exception, nil,
"Global_immutable_vars::global_immutable_var is writable (expected to be immutable)")
had_exception = false
begin
Global_immutable_vars::specific_immutable_var = 81
rescue NoMethodError => e
had_exception = true
end
swig_assert(had_exception, nil,
"Global_immutable_vars::specific_immutable_var is writable (expected to be immutable)")

View file

@ -0,0 +1,47 @@
#!/usr/bin/env ruby
#
# C++ version of ruby_global_immutable_vars_runme.rb.
#
require 'swig_assert'
require 'ruby_global_immutable_vars_cpp'
# first check if all variables can be read
swig_assert_each_line( <<EOF )
$default_mutable_var == 40
$global_immutable_var == 41
$specific_mutable_var == 42
$global_mutable_var == 43
$specific_immutable_var == 44
EOF
# check that all mutable variables can be modified
swig_assert_each_line( <<EOF )
$default_mutable_var = 80
$default_mutable_var == 80
$specific_mutable_var = 82
$specific_mutable_var == 82
$global_mutable_var = 83
$global_mutable_var == 83
EOF
# now check that immutable variables cannot be modified
had_exception = false
begin
$global_immutable_var = 81
rescue NameError => e
had_exception = true
end
swig_assert(had_exception, nil,
"$global_immutable_var is writable (expected to be immutable)")
had_exception = false
begin
$specific_immutable_var = 81
rescue NameError => e
had_exception = true
end
swig_assert(had_exception, nil,
"$specific_immutable_var is writable (expected to be immutable)")

View file

@ -0,0 +1,51 @@
#!/usr/bin/env ruby
#
# This test program is similar to global_immutable_vars_runme.rb
# with the difference that the global variables to check are also
# Ruby global variables (SWIG Ruby option "-globalmodule").
#
# Immutable global variables shall throw a NameError exception.
#
require 'swig_assert'
require 'ruby_global_immutable_vars'
# first check if all variables can be read
swig_assert_each_line( <<EOF )
$default_mutable_var == 40
$global_immutable_var == 41
$specific_mutable_var == 42
$global_mutable_var == 43
$specific_immutable_var == 44
EOF
# check that all mutable variables can be modified
swig_assert_each_line( <<EOF )
$default_mutable_var = 80
$default_mutable_var == 80
$specific_mutable_var = 82
$specific_mutable_var == 82
$global_mutable_var = 83
$global_mutable_var == 83
EOF
# now check that immutable variables cannot be modified
had_exception = false
begin
$global_immutable_var = 81
rescue NameError => e
had_exception = true
end
swig_assert(had_exception, nil,
"$global_immutable_var is writable (expected to be immutable)")
had_exception = false
begin
$specific_immutable_var = 81
rescue NameError => e
had_exception = true
end
swig_assert(had_exception, nil,
"$specific_immutable_var is writable (expected to be immutable)")

View file

@ -0,0 +1,25 @@
%module ruby_global_immutable_vars
// This copy of global_immutable_vars.i shall be compiled with the
// SWIG Ruby option "-globalmodule" in order to check the code path
// for registering global methods (in contrast to module methods).
%inline %{
int default_mutable_var = 40;
%}
%immutable;
%feature("immutable", "0") specific_mutable_var;
%inline %{
int global_immutable_var = 41;
int specific_mutable_var = 42;
%}
%mutable;
%immutable specific_immutable_var;
%inline %{
int global_mutable_var = 43;
int specific_immutable_var = 44;
%}

View file

@ -0,0 +1,23 @@
%module ruby_global_immutable_vars_cpp
// C++ version of ruby_global_immutable_vars.i
%inline %{
int default_mutable_var = 40;
%}
%immutable;
%feature("immutable", "0") specific_mutable_var;
%inline %{
int global_immutable_var = 41;
int specific_mutable_var = 42;
%}
%mutable;
%immutable specific_immutable_var;
%inline %{
int global_mutable_var = 43;
int specific_immutable_var = 44;
%}