From ab8ecbc208071e1c2a6cf0b4ee1ee23351ae7ed3 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Fri, 22 May 2020 15:58:21 +0200 Subject: [PATCH 1/2] Use '\\' instead of "\\" No real changes, just use simpler quoting construct which is sufficient (as we don't need to expand any variables) and also happens not to break Vim 8 syntax highlighting in the entire file, unlike double quotes. --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b4cadefd0..ab7de511b 100644 --- a/configure.ac +++ b/configure.ac @@ -622,7 +622,7 @@ else PYEPREFIX=`($PYTHON -c "import sys; sys.stdout.write(sys.exec_prefix)") 2>/dev/null` AC_MSG_RESULT($PYEPREFIX) - if test x"$PYOSNAME" = x"nt" -a x"$PYSEPARATOR" = x"\\"; then + if test x"$PYOSNAME" = x"nt" -a x"$PYSEPARATOR" = x'\\'; then # Windows installations are quite different to posix installations (MinGW path separator is a forward slash) PYPREFIX=`echo "$PYPREFIX" | sed -e 's,\\\\,/,g'` # Forward slashes are easier to use and even work on Windows most of the time PYTHON_SO=.pyd @@ -739,7 +739,7 @@ else PYVER=0 fi if test "x$PY3BIN" = xyes; then - if test x"$PYOSNAME" = x"nt" -a x"$PYSEPARATOR" = x"\\" -a $PYVER -ge 3; then + if test x"$PYOSNAME" = x"nt" -a x"$PYSEPARATOR" = x'\\' -a $PYVER -ge 3; then PYTHON3="$PYTHON" else for py_ver in 3 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 ""; do @@ -774,7 +774,7 @@ else PYSEPARATOR=`($PYTHON3 -c "import sys, os; sys.stdout.write(os.sep)") 2>/dev/null` AC_MSG_RESULT($PYSEPARATOR) - if test x"$PY3OSNAME" = x"nt" -a x"$PYSEPARATOR" = x"\\"; then + if test x"$PY3OSNAME" = x"nt" -a x"$PYSEPARATOR" = x'\\'; then # Windows installations are quite different to posix installations # There is no python-config to use AC_MSG_CHECKING(for Python 3.x prefix) From 6c5d00bd0d57e9a9a46ae0f378463f4038e7c42a Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Fri, 22 May 2020 16:17:45 +0200 Subject: [PATCH 2/2] Ignore ambiguous variable names error from pycodestyle 2.6 This error is given for any use of variable called "l" (and also "I" and "O", but we don't seem to have any of those) and it doesn't seem to be worth changing this variable name in the tests code, as it's really not that meaningful there anyhow, so just disable the warning to let the CI builds, which now use pycodestyle 2.6, instead of 2.5 which didn't have this error and which is still the latest available in Debian Sid, pass. --- Examples/test-suite/python/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Examples/test-suite/python/Makefile.in b/Examples/test-suite/python/Makefile.in index be06f7e51..4c0507cbb 100644 --- a/Examples/test-suite/python/Makefile.in +++ b/Examples/test-suite/python/Makefile.in @@ -11,7 +11,7 @@ endif LANGUAGE = python PYTHON = $(PYBIN) PYCODESTYLE = @PYCODESTYLE@ -PYCODESTYLE_FLAGS = --ignore=E252,E30,E402,E501,E731,W291,W391 +PYCODESTYLE_FLAGS = --ignore=E252,E30,E402,E501,E731,E741,W291,W391 #*_runme.py for Python 2.x, *_runme3.py for Python 3.x PY2SCRIPTSUFFIX = _runme.py