Merge pull request #302 from puremourning/updated-go

Update vscode-go to latest version

README.md

@@ -1198,6 +1198,9 @@ Requires:
 }
 ```
 
+See the vscode-go docs for
+[troubleshooting information](https://github.com/golang/vscode-go/blob/master/docs/debugging.md#troubleshooting)
+
 ## PHP
 
 This uses the php-debug, see

python3/vimspector/breakpoints.py

@@ -219,10 +219,14 @@ class ProjectBreakpoints( object ):
 
 
   def ClearTemporaryBreakpoints( self ):
+    to_delete = []
     for file_name, breakpoints in self._line_breakpoints.items():
-      self._line_breakpoints[ file_name ] = list( filter(
-        lambda bp: not bp[ 'options' ].get( 'temporary' ),
-        breakpoints ) )
+      for index, bp in enumerate( breakpoints ):
+        if bp[ 'options' ].get( 'temporary' ):
+          to_delete.append( ( bp, file_name, index ) )
+
+    for entry in to_delete:
+      self._DeleteLineBreakpoint( *entry )
 
 
   def _UpdateTemporaryBreakpoints( self, breakpoints, temp_idxs ):

python3/vimspector/gadgets.py

@@ -353,10 +353,10 @@ GADGETS = {
              'v${version}/${file_name}'
     },
     'all': {
-      'version': '0.17.2',
-      'file_name': 'Go-0.17.2.vsix',
+      'version': '0.18.1',
+      'file_name': 'Go-0.18.1.vsix',
       'checksum':
-        '69055b9b86387e2906f20cceb84ab2c4da86c5a5159395a7bbdb74ea3a0f982f',
+        '80d4522c6cf482cfa6141997e5b458034f67d7065d92e1ce24a0456c405d6061',
     },
     'adapters': {
       'vscode-go': {

support/test/go/hello_world/.vimspector.json

@@ -2,6 +2,7 @@
   "configurations": {
     "run": {
       "adapter": "vscode-go",
+      "default": true,
       "configuration": {
         "request": "launch",
         "program": "${workspaceRoot}/hello-world.go",
@@ -10,6 +11,20 @@
         "trace": true,
         "env": { "GO111MODULE": "off" }
       }
+    },
+    "run-exec": {
+      // NOTE: To use this you _must_ disable optimistaion:
+      // go build -o hello_world -gcflags="all=-N -l"
+      // https://github.com/golang/vscode-go/blob/master/docs/debugging.md#troubleshooting
+      "adapter": "vscode-go",
+      "configuration": {
+        "request": "launch",
+        "program": "${workspaceRoot}/hello-world",
+        "mode": "exec",
+        "dlvToolPath": "$HOME/go/bin/dlv",
+        "trace": true,
+        "env": { "GO111MODULE": "off" }
+      }
     }
   }
 }

tests/lib/run_test.vim

@@ -371,7 +371,7 @@ for s:test in sort(s:tests)
   if len(v:errors) > 0
         \ && $TEST_NO_RETRY == ''
         \ && g:test_is_flaky
-    for retry in range( 5 )
+    for retry in range( 10 )
       call add( s:messages, 'Found errors in ' . s:test . '. Retrying.' )
       call extend( s:messages, v:errors )