From b65d9536ad8a0cf79fd8bf11fff4514884ddba19 Mon Sep 17 00:00:00 2001 From: cposture Date: Tue, 15 Dec 2020 00:22:35 +0800 Subject: [PATCH 1/4] update gadgets vscode-go version --- python3/vimspector/gadgets.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python3/vimspector/gadgets.py b/python3/vimspector/gadgets.py index 2ea6bbc..0271069 100644 --- a/python3/vimspector/gadgets.py +++ b/python3/vimspector/gadgets.py @@ -353,10 +353,10 @@ GADGETS = { 'v${version}/${file_name}' }, 'all': { - 'version': '0.18.1', - 'file_name': 'Go-0.18.1.vsix', + 'version': '0.19.1', + 'file_name': 'go-0.19.1.vsix', 'checksum': - '80d4522c6cf482cfa6141997e5b458034f67d7065d92e1ce24a0456c405d6061', + '7f9dc014245b030d9f562b28f3ea9b1fd6e2708fac996c53ff6a707f8204ec64', }, 'adapters': { 'vscode-go': { From f161ce1e8cc62a956083d5b1d80c3499d614c5f5 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Mon, 14 Dec 2020 16:14:02 +0000 Subject: [PATCH 2/4] Remove redundant comments --- plugin/vimspector.vim | 5 ----- 1 file changed, 5 deletions(-) diff --git a/plugin/vimspector.vim b/plugin/vimspector.vim index 2dbbd82..05245cd 100644 --- a/plugin/vimspector.vim +++ b/plugin/vimspector.vim @@ -28,11 +28,6 @@ if exists( 'g:loaded_vimpector' ) endif "}}} -" TODO: -" - Check Vim version (for jobs) -" - Check python support -" - Add commands/mappings/menus? - let g:loaded_vimpector = 1 let g:vimspector_home = expand( ':p:h:h' ) From 61179b7670491a70b40cb34ddeefe793bee7fcb8 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Mon, 14 Dec 2020 20:54:58 +0000 Subject: [PATCH 3/4] Update CONTRIBUTING.md for PRs --- CONTRIBUTING.md | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cfa6c9d..067f7dc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -88,6 +88,42 @@ vim -Nu /path/to/vimspector/support/minimal_vimrc ## Pull Requests +Vimspector is open to all contributors with ideas great and small! However, +there is a limit to the intended scope of the plugin and the amount of time the +maintainer has to support and... well... maintain features. It's probably well +understood that the contributor's input typically ends when a PR is megred, but +the maintainers have to keep it working forever. + +### Small changes + +For bug fixes, documentation changes, gadget versin updates, etc. please just +send a PR, I'm super happy to merge these! + +If you are unsure, or looking for some pointers, feel free to ask in Gitter, or +mention is in the PR. + +### Larger changes + +For larger features that might be in any way controvertial, or increase the +complexity of the overall plugin, please come to Gitter and talk to the +maintainer(s) first. This saves a lot of potential back-and-forth and makes sure +that we're "on the same page" about the idea and the ongoing maintenance. + +In addition, if you like hacking, feel free to raise a PR tagged with `[RFC]` in +the title and we can discuss the idea. I still prefer to discuss these things on +Gitter rather than back-and-forth on GitHub, though. + +Please don't be offended if the maintainer(s) request significant rework for (or +perhaps even dismiss) a PR that's not gone through this process. + +Please also don't be offended if the maintainer(s) ask if you're willing to +provide ongoing support for the feature. As an OSS project manned entirely in +what little spare time the maintainer(s) have, we're always looking for +contributions and contributors who will help with support and maintenance of +larger new features. + +### PR Guidelines + When contributing pull requests, I ask that: * You provide a clear and complete summary of the change, the use case and how @@ -95,6 +131,8 @@ When contributing pull requests, I ask that: * You avoid using APIs that are not available in the versions listed in the dependencies on README.md * You add tests for your PR. +* You test your changes in both Vim and Neovim at the supported versions (and + state that in the PR). * You follow the style of the code as-is; the python code is YCM-stye, it is *not* PEP8, nor should it be. From f8d1e484f95e742ea6dac3cdcaeb94a64c501e78 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Fri, 18 Dec 2020 17:10:29 +0000 Subject: [PATCH 4/4] Update CONTRIBUTING.md Minor fix and correct CI path --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 067f7dc..3ba53bf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -167,10 +167,10 @@ Vimspector creator. ### Code Style The code style of the Python code is "YCM" style, because that's how I like it. -[`flake8`][] is used to check for certain errors and code style. +`flake8` is used to check for certain errors and code style. The code style of the Vimscript is largely the same, and it is linted by -[`vint`][]. +`vint`. To run them: @@ -182,7 +182,7 @@ To run them: They're also run by CI, so please check for lint failures. The canonical definition of the command to run is the command run in CI, i.e. in -`azure-pipelines.yml`. +`.git/workflows/build.yml`. # Code of conduct