jyapayne/houserules
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(sisyphus): mark T3 Wave 2 (15 primitives) complete + notepad updates

Browse source
This commit is contained in:
Joey Yakimowich-Payne 2026-04-19 17:42:32 -06:00
commit 8a7c1b3f54
No known key found for this signature in database
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.sisyphus/notepads/modifier-profiles-t3/learnings.md
View file

@ -20,3 +20,7 @@
- Mirrored `MODIFIER_REGISTRY` class shape exactly: private `Map`, duplicate guard throw, `register/get/list/has`, generic register call-site support.
- Added `packages/chess/src/modifiers/primitives/index.ts` barrel with explicit Wave-2 side-effect-registration stub comment.
- Added `packages/chess/src/modifiers/primitives/registry.test.ts` with 6 scenarios: round-trip get, duplicate throw, list order stability, `has()` accuracy, unknown kind miss, and generic type preservation at register call site.
## [2026-04-19 17:28] Wave 2 batch B
- Added `absorb-damage-with-attribute` primitive + tests.

8
.sisyphus/plans/modifier-profiles-t3.md
View file

@ -294,7 +294,7 @@ Wave FINAL (4 parallel reviewers):
*(Abbreviated — each task follows the same 7-section format as T1/T2. Full details TBD when executing.)*
- [ ] 1. **T3-ADR documentation**
- [x] 1. **T3-ADR documentation**
**What to do**: Append T3-ADR-1 through T3-ADR-7 to `docs/adr/modifier-profiles.md`.
@ -304,7 +304,7 @@ Wave FINAL (4 parallel reviewers):
**Commit**: `docs(adr): T3 custom modifier DSL architecture decisions`
- [ ] 2. **Primitive types + registry class**
- [x] 2. **Primitive types + registry class**
**What to do**: Create `packages/chess/src/modifiers/primitives/types.ts` (EffectPrimitive, PrimitiveKind, parameter type families). Create `primitives/registry.ts` with `PRIMITIVE_REGISTRY` singleton.
@ -314,7 +314,7 @@ Wave FINAL (4 parallel reviewers):
**Commit**: `feat(engine): primitive types and registry`
- [ ] 3. **Custom modifier descriptor types**
- [x] 3. **Custom modifier descriptor types**
**What to do**: Create `packages/chess/src/modifiers/custom/types.ts` — `CustomModifierDescriptor` shape with { id, name, description, version, primitives[], targetAttrs[] }.
@ -324,7 +324,7 @@ Wave FINAL (4 parallel reviewers):
**Commit**: `feat(engine): custom modifier descriptor types`
- [ ] 4-18. **15 primitive implementations** (one per primitive)
- [x] 4-18. **15 primitive implementations** (one per primitive)
**Pattern** (one task per primitive):
- Create `packages/chess/src/modifiers/primitives/{kind}.ts`: