jyapayne/karax
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

components work without 'key' attribute set

Browse source
This commit is contained in:
Andreas Rumpf 2017-07-12 13:23:58 +02:00
commit e94071b077
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/karax.nim
View file

@ -228,9 +228,9 @@ proc eq(a, b: VNode): EqResult =
if a.text != b.text:
when defined(profileKarax): inc reasons[deComponent]
return different
if VComponent(a).key.isNil and VComponent(b).key.isNil:
when defined(profileKarax): inc reasons[deComponent]
return different
#if VComponent(a).key.isNil and VComponent(b).key.isNil:
# when defined(profileKarax): inc reasons[deComponent]
# return different
if VComponent(a).key != VComponent(b).key:
when defined(profileKarax): inc reasons[deComponent]
return different

2
tests/components.nim
View file

@ -54,7 +54,7 @@ proc newTextInput*(style: VStyle = VStyle(); key: cstring;
result = newComponent(TextInput, render, changed=changed, updated=update)
result.style = style
result.value = value
result.key = key
#result.key = key
when false:
type