jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

✅ (index.tsx): add data-testid attribute to save button for better testability

Browse source 
✅ (flowSettings.spec.ts): update test to use data-testid for save button click
This commit is contained in:
cristhianzl 2024-06-03 18:47:57 -03:00
commit 3925d15eaa
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/frontend/src/modals/flowSettingsModal/index.tsx
View file

@ -75,6 +75,7 @@ export default function FlowSettingsModal({
disabled={nameLists.includes(name) && name !== currentFlow!.name}
onClick={handleClick}
type="submit"
data-testid="save-flow-settings-button"
>
Save
</Button>

3
src/frontend/tests/end-to-end/flowSettings.spec.ts
View file

@ -43,9 +43,8 @@ test("flowSettings", async ({ page }) => {
.fill(
"Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test",
);
await page.getByTestId("save-flow-settings-button").click();
await page.getByText("Save").last().click();
await page.waitForTimeout(1000);
await page.getByText("Changes saved successfully").isVisible();