jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(ui): improve SettingsVoiceModal functionality and alignment (#8433)

Browse source 
* 🐛 (audio-settings-dialog.tsx): fix alignment offset in DropdownMenuContent component
📝 (audio-settings-dialog.tsx): remove unnecessary check for empty value in handleOpenAIKeyChange function

* ✨ (freeze.spec.ts): add support for adding a flow to test on an empty langflow if the first run langflow is greater than 0

* ✅ (freeze.spec.ts): update timeout values for page.waitForSelector to improve test reliability and prevent false negatives

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
This commit is contained in:
Cristhian Zanforlin Lousa 2025-06-16 12:30:02 -03:00 • committed by GitHub
commit 5c38d0223d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/frontend/src/modals/IOModal/components/chatView/chatInput/components/voice-assistant/components/audio-settings/audio-settings-dialog.tsx
View file

@ -218,7 +218,6 @@ const SettingsVoiceModal = ({
}; };
const handleOpenAIKeyChange = (value: string) => { const handleOpenAIKeyChange = (value: string) => {
if (!value) return;
setOpenaiApiKey(value); setOpenaiApiKey(value);
}; };
@ -263,7 +262,7 @@ const SettingsVoiceModal = ({
<DropdownMenuContent <DropdownMenuContent
className="w-[324px] rounded-xl shadow-lg" className="w-[324px] rounded-xl shadow-lg"
sideOffset={18} sideOffset={18}
alignOffset={-54} alignOffset={-60}
align="end" align="end"
> >
<div ref={popupRef} className="rounded-3xl"> <div ref={popupRef} className="rounded-3xl">
@ -291,7 +290,7 @@ const SettingsVoiceModal = ({
<> <>
<InputComponent <InputComponent
isObjectOption={false} isObjectOption={false}
password={false} password
nodeStyle nodeStyle
popoverWidth="16rem" popoverWidth="16rem"
placeholder={getPlaceholder( placeholder={getPlaceholder(

10
src/frontend/tests/core/features/freeze.spec.ts
View file

@ -164,7 +164,9 @@ test(
await page.getByTestId("button_run_chat output").click(); await page.getByTestId("button_run_chat output").click();
await page.waitForSelector("text=built successfully", { timeout: 30000 }); await page.waitForSelector("text=built successfully", {
timeout: 30000 * 3,
});
await page.waitForSelector( await page.waitForSelector(
'[data-testid="output-inspection-output message-chatoutput"]', '[data-testid="output-inspection-output message-chatoutput"]',
@ -189,7 +191,7 @@ test(
await page.getByTestId("button_run_chat output").click(); await page.getByTestId("button_run_chat output").click();
await page.waitForSelector("text=built successfully", { await page.waitForSelector("text=built successfully", {
timeout: 30000 * 2, timeout: 30000 * 3,
}); });
await page.waitForSelector( await page.waitForSelector(
@ -243,7 +245,9 @@ test(
await page.getByTestId("button_run_chat output").click(); await page.getByTestId("button_run_chat output").click();
await page.waitForSelector("text=built successfully", { timeout: 30000 }); await page.waitForSelector("text=built successfully", {
timeout: 30000 * 3,
});
await page.waitForSelector( await page.waitForSelector(
'[data-testid="output-inspection-output message-chatoutput"]', '[data-testid="output-inspection-output message-chatoutput"]',