jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

🔧 refactor(base.py): remove unnecessary condition in get_signature method

Browse source 
The condition `name in settings.<type>` is removed from the `get_signature` method in the `base.py` files of the `agents`, `chains`, `memories`, and `prompts` modules. This condition was unnecessary as it was already checked in the `get_custom_nodes` function. Removing this condition simplifies the code and improves readability.
This commit is contained in:
Gabriel Luiz Freitas Almeida 2023-07-06 17:35:25 -03:00
commit 6675592737
4 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/backend/langflow/interface/agents/base.py
View file

@ -32,10 +32,7 @@ class AgentCreator(LangChainTypeCreator):
def get_signature(self, name: str) -> Optional[Dict]: def get_signature(self, name: str) -> Optional[Dict]:
try: try:
if ( if name in get_custom_nodes(self.type_name).keys():
name in get_custom_nodes(self.type_name).keys()
and name in settings.agents
):
return get_custom_nodes(self.type_name)[name] return get_custom_nodes(self.type_name)[name]
elif name in self.from_method_nodes: elif name in self.from_method_nodes:
return build_template_from_method( return build_template_from_method(

5
src/backend/langflow/interface/chains/base.py
View file

@ -45,10 +45,7 @@ class ChainCreator(LangChainTypeCreator):
def get_signature(self, name: str) -> Optional[Dict]: def get_signature(self, name: str) -> Optional[Dict]:
try: try:
if ( if name in get_custom_nodes(self.type_name).keys():
name in get_custom_nodes(self.type_name).keys()
and name in settings.chains
):
return get_custom_nodes(self.type_name)[name] return get_custom_nodes(self.type_name)[name]
elif name in self.from_method_nodes.keys(): elif name in self.from_method_nodes.keys():
return build_template_from_method( return build_template_from_method(

5
src/backend/langflow/interface/memories/base.py
View file

@ -32,10 +32,7 @@ class MemoryCreator(LangChainTypeCreator):
def get_signature(self, name: str) -> Optional[Dict]: def get_signature(self, name: str) -> Optional[Dict]:
"""Get the signature of a memory.""" """Get the signature of a memory."""
try: try:
if ( if name in get_custom_nodes(self.type_name).keys():
name in get_custom_nodes(self.type_name).keys()
and name in settings.memories
):
return get_custom_nodes(self.type_name)[name] return get_custom_nodes(self.type_name)[name]
elif name in self.from_method_nodes: elif name in self.from_method_nodes:
return build_template_from_method( return build_template_from_method(

5
src/backend/langflow/interface/prompts/base.py
View file

@ -40,10 +40,7 @@ class PromptCreator(LangChainTypeCreator):
def get_signature(self, name: str) -> Optional[Dict]: def get_signature(self, name: str) -> Optional[Dict]:
try: try:
if ( if name in get_custom_nodes(self.type_name).keys():
name in get_custom_nodes(self.type_name).keys()
and name in settings.prompts
):
return get_custom_nodes(self.type_name)[name] return get_custom_nodes(self.type_name)[name]
return build_template_from_class(name, self.type_to_loader_dict) return build_template_from_class(name, self.type_to_loader_dict)
except ValueError as exc: except ValueError as exc: