🐛 fix(vector_store.py): remove redundant code and fix parameter naming
The `initialize_chroma` function had redundant code that was removed. The `embedding_function` parameter was renamed to `embedding` to match the parameter name used in the `class_object` constructor. The `documents` and `texts` parameters were being used interchangeably, so the code was updated to use only `documents`.
This commit is contained in:
parent
1103a22870
commit
7cebb8215f
1 changed files with 5 additions and 2 deletions
|
|
@ -122,6 +122,11 @@ def initialize_chroma(class_object: Type[Chroma], params: dict):
|
|||
"""Initialize a ChromaDB object from the params"""
|
||||
persist = params.pop("persist", False)
|
||||
if not docs_in_params(params):
|
||||
params.pop("documents", None)
|
||||
params.pop("texts", None)
|
||||
params["embedding_function"] = params.pop("embedding")
|
||||
chromadb = class_object(**params)
|
||||
else:
|
||||
if "texts" in params:
|
||||
params["documents"] = params.pop("texts")
|
||||
for doc in params["documents"]:
|
||||
|
|
@ -131,8 +136,6 @@ def initialize_chroma(class_object: Type[Chroma], params: dict):
|
|||
if value is None:
|
||||
doc.metadata[key] = ""
|
||||
chromadb = class_object.from_documents(**params)
|
||||
else:
|
||||
chromadb = class_object(**params)
|
||||
if persist:
|
||||
chromadb.persist()
|
||||
return chromadb
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue