🐛 fix(store.py): change return value from dictionary to UsersLikesResponse object to improve readability and maintainability
🐛 fix(service.py): handle case when component is not found and raise ValueError to provide more informative error message
This commit is contained in:
parent
68198bfd41
commit
85647091f7
2 changed files with 5 additions and 2 deletions
|
|
@ -202,6 +202,6 @@ def like_component(
|
|||
likes_count = store_service.get_component_likes_count(
|
||||
store_api_Key, component_id
|
||||
)
|
||||
return {"likes": likes_count, "liked_by_user": result}
|
||||
return UsersLikesResponse(likes_count=likes_count, liked_by_user=result)
|
||||
except Exception as exc:
|
||||
raise HTTPException(status_code=500, detail=str(exc))
|
||||
|
|
|
|||
|
|
@ -314,7 +314,10 @@ class StoreService(Service):
|
|||
params = {
|
||||
"fields": ",".join(["id", "count(liked_by)"]),
|
||||
}
|
||||
likes = self._get(url, api_key, params)
|
||||
result = self._get(url, api_key, params)
|
||||
if len(result) == 0:
|
||||
raise ValueError("Component not found")
|
||||
likes = result[0]["liked_by_count"]
|
||||
return likes
|
||||
|
||||
def like_component(self, api_key: str, component_id: str) -> bool:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue