jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

🐛 fix(store.py): change return value from dictionary to UsersLikesResponse object to improve readability and maintainability

Browse source 
🐛 fix(service.py): handle case when component is not found and raise ValueError to provide more informative error message
This commit is contained in:
Gabriel Luiz Freitas Almeida 2023-11-01 09:52:35 -03:00
commit 85647091f7
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/backend/langflow/api/v1/store.py
View file

@ -202,6 +202,6 @@ def like_component(
likes_count = store_service.get_component_likes_count( likes_count = store_service.get_component_likes_count(
store_api_Key, component_id store_api_Key, component_id
) )
return {"likes": likes_count, "liked_by_user": result} return UsersLikesResponse(likes_count=likes_count, liked_by_user=result)
except Exception as exc: except Exception as exc:
raise HTTPException(status_code=500, detail=str(exc)) raise HTTPException(status_code=500, detail=str(exc))

5
src/backend/langflow/services/store/service.py
View file

@ -314,7 +314,10 @@ class StoreService(Service):
params = { params = {
"fields": ",".join(["id", "count(liked_by)"]), "fields": ",".join(["id", "count(liked_by)"]),
} }
likes = self._get(url, api_key, params) result = self._get(url, api_key, params)
if len(result) == 0:
raise ValueError("Component not found")
likes = result[0]["liked_by_count"]
return likes return likes
def like_component(self, api_key: str, component_id: str) -> bool: def like_component(self, api_key: str, component_id: str) -> bool: