Commit graph

806 commits

Author SHA1 Message Date
Araq
8bdc054817 fixes #703 2019-09-20 20:09:37 +01:00
Neelesh Chandola
d6a6a47dd9 Fix https://github.com/nim-lang/nimble/issues/700 2019-09-17 21:23:54 +01:00
Ivan Bobev
46f26e1d4a Move ignored from tests dir to its .gitignore
Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
1880730762 Fix the test for recursive calling of Nimble tasks
The test case for recursive calling of Nimble tasks was not working
properly on Windows so far.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
62699afaa8 Revert deletion of two not used procedures
The two currently not used procedures `getSpecificDir` and `doPull` from
`download.nim` file are reverted according to dom96's suggestion in the
code review of pull request #692. Now they are marked with used pragma
to disable the warning.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
df11a6f6cf Fix tests to pass with the latest Nim
There are two issues fixed:

 - With the latest Nim version sometimes the files
   `<package_name>_<some_number>.nims`' generated on `nim install`
   contain warning for unused imports which causes the test
   "can validate package structure (#144)" to fail, because it was
   searching for the word "warning" in the output.

 - On Windows Subsystem for Linux, when an import starts sometimes with
   a lowercase, and sometimes with an uppercase, for example
   `import uri` and `import Uri`, this causes Nim to create and compile
   both `stdlib_uri.nim.c` and `stdlib_Uri.nim.c` and to fail on the
   linking step, because of the same symbols are being redefined.

Also the Travis CI build script is changed to test against currently the
latest working Nim version 212ae2f.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
9d8cc06724 Add additional directory to .gitignore
The directory "tests/buildDir/" where the build artifacts from the
"compilation without warnings" unit test execution are being written is
added to the .gitignore file.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
f0c454a399 Fix compilation without warnings test case
Compilation without warnings test case on Unix systems with older Nim
version 0.19.6 had been failing before the fix, because the compiler
expects full file name to be passed after the '-o' switch, but not only
an output directory name.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
427b412ff9 Fix unused import warning on Unix systems
The NimbleError exception from the version module is being used only on
Windows platforms in the packageinstaller.nim file. Conditional import
of the module is used to fix the warning.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
bb1dd21224 Add an unit test for compilation without warnings
An unit test which checks whether Nimble compiles without warnings is
added. Checking for three warning types cleaned in previous commits is
implemented:

 - [UnusedImport] cleaned in e8c7d5c

 - [Deprecated] cleaned in 3d6172e

 - [XDeclaredButNotUsed] cleaned in 7df2ef3

Other types of warnings easily can be added to the test by extending the
warnings list.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
1eb9f0f01c Remove unused file
The file nimscriptsupport.nim is no longer used in favor of the newer
version nimscriptwrapper.nim.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
bfc4f25548 Fix compilation of nimscriptapi.nim
To compile the nimscriptapi.nim file, it is needed to import the os
module, but if so the getParams procedure cannot be executed from
nimscript any more. The problem is resolved by conditionally importing
the module.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
6e5761b192 Clear unused symbols warnings
Unused functions and variables are removed from the Nimble's source
code.

Resolves #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
db018f235b Clear deprecation warnings
This fix clears deprecation warnings related to Nim's HashSet
procedures. There were two types of warnings which have been fixed:

 - Warning: Deprecated since v0.20, use 'initHashSet'; initSet is
   deprecated [Deprecated]

 - Warning: Deprecated since v0.20, use 'toHashSet'; toSet is
   deprecated [Deprecated]

Backward compatibility with older Nim versions is also implemented.

Related to #680
2019-09-07 12:08:15 +01:00
Ivan Bobev
2ec470d287 Clear unused imports
Related to #680
2019-09-07 12:08:15 +01:00
Ganesh Viswanathan
38cd55e71a Fix #689 - don't lookup versions for aliases 2019-09-04 23:14:29 +02:00
Dominik Picheta
1af4505219
Merge pull request #698 from genotrance/issue640
Fix #640 - strip out blank spaces
2019-09-04 23:12:53 +02:00
Ganesh Viswanathan
fb57d47421 Fix #640 - strip out blank spaces 2019-09-04 13:17:17 -05:00
genotrance
e39c57482a Fix #633 - pass CLI to tasks (#686)
* Fix #633 - pass CLI to tasks

* Add test case
2019-09-02 22:54:48 +01:00
Hitesh Jasani
2243e3fbc2 Fix #567: Display package versions in sorted order (#688)
* Fix #567: Display package versions in sorted order

* Add docs

* Fix docs to focus on git tags

* Refactor to use version module

* Streamline docs

* Refactor to make things work in nim <= 0.19.6

* Improve code readability
2019-08-24 10:15:29 +01:00
Ivan Bobev
da82e3111e Fix issue678 test repository links
After the ownership of the issue678 test repository was transferred to
the nimble-test account, the links to the repository required for
performing the test had to be updated in order to avoid possible
confusion, despite the fact that GitHub does automatic link redirection
for transferred repositories.

Related to #687
2019-08-04 19:20:53 +01:00
Ivan Bobev
8e3af03e46 Add a changelog entry for the issue #678 fix
Related to #678
2019-07-29 11:56:09 +01:00
Ivan Bobev
f461792686 Fix multiple installs of the same package
When one package is dependency both of some other package and some other
dependency of the other package it has been downloaded and installed
multiple times.

Resolves #678
2019-07-29 11:56:09 +01:00
Ivan Bobev
8cf97e0e06 Add an unit test for #678
This is an unit test for the issue with multiple downloads and installs
of the same dependency package.

Related to #678
2019-07-29 11:56:09 +01:00
Ivan Bobev
871e5c65d1 Add additional files and folders to .gitignore
Several additional file and folder types are added to .gitignore:

 - VSCode directory for for user and workspace settings.

 - *.orig files created by Git on merge conflicts.

 - Some artifacts related to the test procedure.
2019-07-29 11:56:09 +01:00
Oisín Mac Fhearaí
522ef4cf12 Unescape package description in nimble init 2019-07-27 21:06:18 +01:00
Oisín Mac Fhearaí
5b7b061465 Remove escaping of author name and package description in nimble init,
since it replaces characters used in many names and languages with
escape sequences.
Slightly refactor the code for determining author name, to make it
easier to add other version control systems in future (right now it's
just git and hg).

Also, add some binary test artifacts to .gitignore so they don't accidentally
get committed in future.
2019-07-27 21:06:18 +01:00
SolitudeSF
b5b85489fa Add tests for passNim feature. 2019-07-27 19:18:39 +01:00
SolitudeSF
5ec2ecea77 Add passNim/p flag to pass compiler flags explicitly.
Remove redundant buildFromDir overload.
2019-07-27 19:18:39 +01:00
genotrance
added89acc Fixes #504 (#683)
* Improve messaging for uninstall

* Uninstall if in right order

* Fix CI - cannot looks better

* Raise exception when nothing to remove

* Test case, minor test fix

* 0.19.6 fixes

* Fix Nim devel hash

* Feedback
2019-07-27 14:37:56 +01:00
Leonardo Mariscal
7c2b9f612e Update submodules at checkout time to fix #675 2019-07-16 20:36:39 +01:00
liquid600pgm
5e72840336 Test for the #581 fix 2019-06-22 00:46:21 +01:00
liquid600pgm
153866252d File not overwritten by example code message 2019-06-22 00:46:21 +01:00
liquid600pgm
192ea12ab9 Output message when file already exists 2019-06-22 00:46:21 +01:00
liquid600pgm
df8317585f fixed #581 nimble init does not overwrite existing files with its templates anymore 2019-06-22 00:46:21 +01:00
Hitesh Jasani
98e566adab Add example dependency with git commit [docs] (#669)
* Add example dependency with git commit [docs]

* Update readme.markdown
2019-06-12 21:16:52 +01:00
Ganesh Viswanathan
513780a382 Fix #665 - avoid stdout in printPkgInfo 2019-06-11 21:38:27 +01:00
Ganesh Viswanathan
2c87a7fe5e Add 0.20.0 to test matrix, latest nightlies 2019-06-11 21:34:07 +01:00
Ganesh Viswanathan
d15c8530cb Version 0.10.2 v0.10.2 2019-06-03 21:06:43 +01:00
genotrance
21616e35a7 Fix issue #655 (#661)
* Fix issue #655

* Update nimscriptwrapper.nim
2019-06-02 12:12:20 +01:00
Ganesh Viswanathan
016f42c34a Fix issue #597 - error if bin is a source file 2019-06-02 12:01:49 +01:00
Ganesh Viswanathan
be83dcdca9 Unique nims filename to enable parallelism 2019-06-01 14:27:31 +01:00
Ganesh Viswanathan
374f62614a Improved test naming 2019-06-01 14:27:31 +01:00
Ganesh Viswanathan
8dc036c896 Update Nim versions, fix recursive test 2019-06-01 14:27:31 +01:00
Ganesh Viswanathan
cbd63e61de Fix outfile issue when binary exists 2019-06-01 14:27:31 +01:00
Andreas Rumpf
0e873c2702
Merge pull request #660 from genotrance/nimOldCaseObjects
Fix object variants - nim issue 1286
2019-06-01 10:39:11 +02:00
Ganesh Viswanathan
d800fb4525 Fix object variants - nim issue 1286 2019-05-31 16:58:54 -05:00
Taylor Rose
9beb6e1529 Add backend selection to nimble init 2019-05-30 23:53:04 +01:00
genotrance
06b9b49449 Update to 0.10.0 (#657) v0.10.0
* Update changelog for 0.10.0

* Multi-user systems

* Minor fixes

* Update changelog.markdown
2019-05-27 19:29:19 +01:00
Dominik Picheta
a4eaa5d3d2
Merge pull request #656 from cdunn2001/master
Choose USER-specific tmpdir
2019-05-27 11:24:31 +01:00