Merge branch 'master' into master
This commit is contained in:
commit
f59ba048cb
3 changed files with 44 additions and 11 deletions
|
|
@ -88,6 +88,42 @@ vim -Nu /path/to/vimspector/support/minimal_vimrc
|
||||||
|
|
||||||
## Pull Requests
|
## Pull Requests
|
||||||
|
|
||||||
|
Vimspector is open to all contributors with ideas great and small! However,
|
||||||
|
there is a limit to the intended scope of the plugin and the amount of time the
|
||||||
|
maintainer has to support and... well... maintain features. It's probably well
|
||||||
|
understood that the contributor's input typically ends when a PR is megred, but
|
||||||
|
the maintainers have to keep it working forever.
|
||||||
|
|
||||||
|
### Small changes
|
||||||
|
|
||||||
|
For bug fixes, documentation changes, gadget versin updates, etc. please just
|
||||||
|
send a PR, I'm super happy to merge these!
|
||||||
|
|
||||||
|
If you are unsure, or looking for some pointers, feel free to ask in Gitter, or
|
||||||
|
mention is in the PR.
|
||||||
|
|
||||||
|
### Larger changes
|
||||||
|
|
||||||
|
For larger features that might be in any way controvertial, or increase the
|
||||||
|
complexity of the overall plugin, please come to Gitter and talk to the
|
||||||
|
maintainer(s) first. This saves a lot of potential back-and-forth and makes sure
|
||||||
|
that we're "on the same page" about the idea and the ongoing maintenance.
|
||||||
|
|
||||||
|
In addition, if you like hacking, feel free to raise a PR tagged with `[RFC]` in
|
||||||
|
the title and we can discuss the idea. I still prefer to discuss these things on
|
||||||
|
Gitter rather than back-and-forth on GitHub, though.
|
||||||
|
|
||||||
|
Please don't be offended if the maintainer(s) request significant rework for (or
|
||||||
|
perhaps even dismiss) a PR that's not gone through this process.
|
||||||
|
|
||||||
|
Please also don't be offended if the maintainer(s) ask if you're willing to
|
||||||
|
provide ongoing support for the feature. As an OSS project manned entirely in
|
||||||
|
what little spare time the maintainer(s) have, we're always looking for
|
||||||
|
contributions and contributors who will help with support and maintenance of
|
||||||
|
larger new features.
|
||||||
|
|
||||||
|
### PR Guidelines
|
||||||
|
|
||||||
When contributing pull requests, I ask that:
|
When contributing pull requests, I ask that:
|
||||||
|
|
||||||
* You provide a clear and complete summary of the change, the use case and how
|
* You provide a clear and complete summary of the change, the use case and how
|
||||||
|
|
@ -95,6 +131,8 @@ When contributing pull requests, I ask that:
|
||||||
* You avoid using APIs that are not available in the versions listed in the
|
* You avoid using APIs that are not available in the versions listed in the
|
||||||
dependencies on README.md
|
dependencies on README.md
|
||||||
* You add tests for your PR.
|
* You add tests for your PR.
|
||||||
|
* You test your changes in both Vim and Neovim at the supported versions (and
|
||||||
|
state that in the PR).
|
||||||
* You follow the style of the code as-is; the python code is YCM-stye, it is
|
* You follow the style of the code as-is; the python code is YCM-stye, it is
|
||||||
*not* PEP8, nor should it be.
|
*not* PEP8, nor should it be.
|
||||||
|
|
||||||
|
|
@ -129,10 +167,10 @@ Vimspector creator.
|
||||||
### Code Style
|
### Code Style
|
||||||
|
|
||||||
The code style of the Python code is "YCM" style, because that's how I like it.
|
The code style of the Python code is "YCM" style, because that's how I like it.
|
||||||
[`flake8`][] is used to check for certain errors and code style.
|
`flake8` is used to check for certain errors and code style.
|
||||||
|
|
||||||
The code style of the Vimscript is largely the same, and it is linted by
|
The code style of the Vimscript is largely the same, and it is linted by
|
||||||
[`vint`][].
|
`vint`.
|
||||||
|
|
||||||
To run them:
|
To run them:
|
||||||
|
|
||||||
|
|
@ -144,7 +182,7 @@ To run them:
|
||||||
|
|
||||||
They're also run by CI, so please check for lint failures. The canonical
|
They're also run by CI, so please check for lint failures. The canonical
|
||||||
definition of the command to run is the command run in CI, i.e. in
|
definition of the command to run is the command run in CI, i.e. in
|
||||||
`azure-pipelines.yml`.
|
`.git/workflows/build.yml`.
|
||||||
|
|
||||||
# Code of conduct
|
# Code of conduct
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -28,11 +28,6 @@ if exists( 'g:loaded_vimpector' )
|
||||||
endif
|
endif
|
||||||
"}}}
|
"}}}
|
||||||
|
|
||||||
" TODO:
|
|
||||||
" - Check Vim version (for jobs)
|
|
||||||
" - Check python support
|
|
||||||
" - Add commands/mappings/menus?
|
|
||||||
|
|
||||||
let g:loaded_vimpector = 1
|
let g:loaded_vimpector = 1
|
||||||
let g:vimspector_home = expand( '<sfile>:p:h:h' )
|
let g:vimspector_home = expand( '<sfile>:p:h:h' )
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -353,10 +353,10 @@ GADGETS = {
|
||||||
'v${version}/${file_name}'
|
'v${version}/${file_name}'
|
||||||
},
|
},
|
||||||
'all': {
|
'all': {
|
||||||
'version': '0.18.1',
|
'version': '0.19.1',
|
||||||
'file_name': 'Go-0.18.1.vsix',
|
'file_name': 'go-0.19.1.vsix',
|
||||||
'checksum':
|
'checksum':
|
||||||
'80d4522c6cf482cfa6141997e5b458034f67d7065d92e1ce24a0456c405d6061',
|
'7f9dc014245b030d9f562b28f3ea9b1fd6e2708fac996c53ff6a707f8204ec64',
|
||||||
},
|
},
|
||||||
'adapters': {
|
'adapters': {
|
||||||
'vscode-go': {
|
'vscode-go': {
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue